1643896 - The pop-up bubble for ImTranslator extension for Firefox stopped working

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[B.J. Herbison]

The ImTranslator add-on creates a pop-up bubble when text is selected. This text appears in Firefox 76.0.1 but not in Nightly.

mozregression shows the problem started with this:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e8d0f18c2300a223c31847d27196d1a8ad673515&tochange=ca3057f6cdc555f3ddfb1f10afa6805a43253a85

The add-on:
https://addons.mozilla.org/en-US/firefox/addon/imtranslator/

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1583484

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: Bug 1643896 - Convert sync onMessage listener exceptions into async rejections

When there are multiple runtime.onMessage listeners in the same context, if
the first one sends a response, but the second one throws, the exception wins
the race because we convert all responses into async promises.

Converting the sync exception into an async promise rejection ensures we process
them in the original order.

Comment 3

[Tomislav Jovanovic :zombie]

This extension is bonkers, the code is awful and it's only by accident that it even worked at all. One of the 4 onMessage listeners in the background page throws whenever it receives a message that every content script sends when it is loaded.

Sad thing is, I'm sure there are other extensions which are similarly broken, so we may as well fix this.

Comment 4

[Tomislav Jovanovic :zombie]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3f82aa47af6ac4ad2f71ffd9e3d637e023b94e4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acd373902b37
Convert sync onMessage listener exceptions into async rejections r=mixedpuppy

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/acd373902b37

Comment 7

[Alex Cornestean]

Hello,

Verified the fix using the latest Nightly (79.0a1/20200617215206) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS. Also reproduced the issue on an older Nightly (79.0a1/20200601214228) for comparison purposes.

When text is selected the pop-up bubble is properly displayed, confirming the fix.