1643898 - Cannot Enable Newly Added Recommended Extensions in 77 Beta

Status: RESOLVED MOVED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[KotW]

Attachment: recording_20200606_132513.mp4-00.00.08.000-00.00.35.320.mp4

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Firefox for Android 77.0.0-beta.2 (77.0.0-beta.2 (Build #2015744451) 42.0.1, 5bf46033e GV: 77.0-20200526221856 AS: 0.58.2) has very recently (for two updates now) allowed users to enable more recommended add-ons.

However, they actually cannot be enabled, as as soon as the user enables the add-on in the add-ons interface, nothing happens and the enabled add-ons keeps on being disabled.

I've attached a video of this behaviour.

Actual results:

The add-ons (HTTPS Everywhere, Privacy Badger, Dark Reader etc.) cannot be enabled even though the interface seems to support it.

Expected results:

The add-ons should be enabled.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

See also https://github.com/mozilla-mobile/fenix/issues/9994

Comment 2

[Arturo Mejia [:amejia]]

(In reply to KotW from comment #0)

Created attachment 9154739 [details]
recording_20200606_132513.mp4-00.00.08.000-00.00.35.320.mp4

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Firefox for Android 77.0.0-beta.2 (77.0.0-beta.2 (Build #2015744451) 42.0.1, 5bf46033e GV: 77.0-20200526221856 AS: 0.58.2) has very recently (for two updates now) allowed users to enable more recommended add-ons.

However, they actually cannot be enabled, as as soon as the user enables the add-on in the add-ons interface, nothing happens and the enabled add-ons keeps on being disabled.

I've attached a video of this behaviour.

Actual results:

The add-ons (HTTPS Everywhere, Privacy Badger, Dark Reader etc.) cannot be enabled even though the interface seems to support it.

Expected results:

The add-ons should be enabled.

KotW at some point, did you see any notification in the status bar staying that there are new add-ons available?

Comment 3

[KotW]

(In reply to Arturo Mejia from comment #2)

(In reply to KotW from comment #0)

Created attachment 9154739 [details]
recording_20200606_132513.mp4-00.00.08.000-00.00.35.320.mp4

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Firefox for Android 77.0.0-beta.2 (77.0.0-beta.2 (Build #2015744451) 42.0.1, 5bf46033e GV: 77.0-20200526221856 AS: 0.58.2) has very recently (for two updates now) allowed users to enable more recommended add-ons.

However, they actually cannot be enabled, as as soon as the user enables the add-on in the add-ons interface, nothing happens and the enabled add-ons keeps on being disabled.

I've attached a video of this behaviour.

Actual results:

The add-ons (HTTPS Everywhere, Privacy Badger, Dark Reader etc.) cannot be enabled even though the interface seems to support it.

Expected results:

The add-ons should be enabled.

KotW at some point, did you see any notification in the status bar staying that there are new add-ons available?

No. The three add-ons (HTTPS Everywhere, Privacy Badger, Dark Reader) were moved from the "Not yet available" section to the "Disabled" section two or three patches ago. I had them installed on the old beta branch of Firefox for Android and they were migrated (turned off) when the beta branch was switched to the Fenix branch. I still have 18 more add-ons waiting in the "Not yet available" section so this is a major issue for me.

I just tried, out of curiosity, whether I could install the two other available recommended add-ons that are also available for installation (NoScript and Search by Image) and I can. I tried installing "Search by Image" which I have never had installed before and it was installed and enabled properly.

Furthermore, I can disable and re-enable it successfully.

This leads me to believe the problem is related to the migration of preinstalled add-ons migrated from the old branch. That said, uBlock Origin was properly migrated and enabled for me before when it was the only available add-on.

Comment 4

[Arturo Mejia [:amejia]]

Thanks for the update. It looks like the migration worked as you can see the add-ons moved from the "Not yet available" section to the "Disabled" section. We have a task that automatically enables the add-ons when they are in that state, it runs every time on startup and once a day, for some reasons is not working for you, so far we don't why and we are not able to reproduce the same issue on our side. To understand what is happening we would need to gather more information, if it's not much trouble, we would need:

• After running the app capture the Android Logcat logs steps.
• Any exceptions registered on Fenix: Go to "Setting" -> "About Firefox Preview" -> "Crashes" send us any entry there.
• The Android version and model of your device.

Sorry for all the trouble, if you need additional help in any of the steps please let us know :)

Comment 5

[KotW]

Attachment: ff-beta-logcat.txt

Requested logcat

Comment 6

[KotW]

(In reply to Arturo Mejia from comment #4)

Thanks for the update. It looks like the migration worked as you can see the add-ons moved from the "Not yet available" section to the "Disabled" section. We have a task that automatically enables the add-ons when they are in that state, it runs every time on startup and once a day, for some reasons is not working for you, so far we don't why and we are not able to reproduce the same issue on our side. To understand what is happening we would need to gather more information, if it's not much trouble, we would need:

• After running the app capture the Android Logcat logs steps.
• Any exceptions registered on Fenix: Go to "Setting" -> "About Firefox Preview" -> "Crashes" send us any entry there.
• The Android version and model of your device.

Sorry for all the trouble, if you need additional help in any of the steps please let us know :)

Added the logcat after opening the browser. I flipped the switches for a little bit while it was running.
(Un)fortunately, there are no "Crash" entries available.
I'm on a Xiaomi Mi A1, Pixel Experience 10.0 Plus (build QQ2A.200501.001.B2
PixelExperience_Plus_tissot-10.0-20200513-0957-OFFICIAL)

Comment 7

[Arturo Mejia [:amejia]]

Thank you for all the information. We found many reports that Xiaomi and other custom Android room devices, impose non-standard and extreme restrictions on background services to try to save battery, as a result, many common tasks break. We are not sure if that is the case for your device, you can try to exclude Firefox using these steps, to a less restricted setting, then kill Firefox and open it again. If that doesn't work, please go to "Setting" -> "Add-ons" -> "Tap any enabled add-on (UBlock Origin)" -> "Details" -> Do a long press on the "Version number e.g 1.27.10" and a popup will appear, please send us a screenshot of it.

Comment 8

[KotW]

Attachment: Screenshot_20200611-215855934.jpg

Requested screenshot

Comment 9

[KotW]

Attachment: Screenshot_20200611-215855934.jpg

Requested screenshot

Comment 10

[KotW]

Attachment: Screenshot_20200611-215918573.jpg

Screenshot

Comment 11

[KotW]

The A1 is an "Android One" phone with stock Android, so any common MIUI problems aren't applicable. I'm on a Google Pixel-based custom ROM anyway :) You can think of this with the feature set of a Pixel phone.

I've attached screenshots.

Comment 12

[Arturo Mejia [:amejia]]

We appreciate all your collaboration, we are really eager to finding out what it's happening. We retested the whole flow, and we were unable to replicate the issue. It will be helpful if you could try re-capture the startup logs, sorry for all the inconveniences. Please follow the steps below:

Capture log on startup

1. Kill the app.
2. Start capturing logs adb logcat
3. Open the app.
4. Save the logs.

Capture log when trying to enable/disable

1. Kill the app.
2. Open the app.
3. Start capturing logs adb logcat
4. Go to the Add-ons Manager screen.
5. Try to enable and disable the any add-on except Ublock.
6. Save the logs.

Comment 13

[KotW]

Attachment: Capture log on startup.txt

Comment 14

[KotW]

Attachment: Capture log when trying to enable-disable.txt

Comment 15

[KotW]

(In reply to Arturo Mejia from comment #12)

We appreciate all your collaboration, we are really eager to finding out what it's happening. We retested the whole flow, and we were unable to replicate the issue. It will be helpful if you could try re-capture the startup logs, sorry for all the inconveniences. Please follow the steps below:

Capture log on startup

1. Kill the app.
2. Start capturing logs adb logcat
3. Open the app.
4. Save the logs.

Capture log when trying to enable/disable

1. Kill the app.
2. Open the app.
3. Start capturing logs adb logcat
4. Go to the Add-ons Manager screen.
5. Try to enable and disable the any add-on except Ublock.
6. Save the logs.

Okay, both attached. Out of the available add-ons, "Search by image" remains the only add-on that can be properly enabled and disabled, and that I didn't have installed before.

Comment 16

[Arturo Mejia [:amejia]]

Thank you so much, for the new logs, we are seeing the issue on them. For some reason, the task that should enable the add-ons is not running, we are trying to figure out why. We've already placed an order to buy a Xiaomi Mi A1 device.

We know we have bothered you a lot, sorry about that, but if you have some extra time, trying this last test could help us a lot to realize what is the issue.

To test you required a Firefox account and be logged.

1. Go to Settings.
2. Account.
3. Start capturing logs adb logcat.
4. Tap Sync Now
5. Search for any entry with the tag SyncWorker, if you can find Starting sync... Tagged as even better. The logged time should correlate with the time that you tapped the Sync Now button.

Thank you so much!

Comment 17

[Sorina Florean [:sflorean]]

Tested this with Xiaomi Redmi Note 8T (Android 9) on Nightly and Beta channels, and couldn't reproduce the issue. Performed 2 scenarios:

• disable the addons > migrate > enable them;
• enable > migrate > disable/enable.

Comment 18

[KotW]

(In reply to Arturo Mejia from comment #16)

Thank you so much, for the new logs, we are seeing the issue on them. For some reason, the task that should enable the add-ons is not running, we are trying to figure out why. We've already placed an order to buy a Xiaomi Mi A1 device.

We know we have bothered you a lot, sorry about that, but if you have some extra time, trying this last test could help us a lot to realize what is the issue.

To test you required a Firefox account and be logged.

1. Go to Settings.
2. Account.
3. Start capturing logs adb logcat.
4. Tap Sync Now
5. Search for any entry with the tag SyncWorker, if you can find Starting sync... Tagged as even better. The logged time should correlate with the time that you tapped the Sync Now button.

Thank you so much!

Sorry, didn't notice this request without a needinfo flag!

Neither tag was found in the logcat feed when I press "Synchronise now", unfortunately.

Comment 19

[KotW]

I filed a different bug for the Sync a while back, by the way: https://bugzilla.mozilla.org/show_bug.cgi?id=1646992

I wouldn't be surprised if these issues are related.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 21

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Closing this bug in favor of https://github.com/mozilla-mobile/fenix/issues/9994