1643935 - Firefox RTL: #restore-button border is wrongly positioned

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Yaron]

Attachment: Correct at top - Wrong at bottom.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Press F11.
Hover over the top.

Actual results:

The #restore-button is not displayed correctly due to the following rule added in FF 77.

#restore-button > .toolbarbutton-icon:-moz-locale-dir(rtl) {
  transform: scaleX(-1);
}

Regardless, I don't understand why the button should be transformed.
In Windows programs (e.g. Notepad) the top "window" in that button is on the left.
Actually, transforming the restore-button when NOT in full-screen would be better (I don't think this is really important either).

Comment 1

[Itiel]

Thanks for reporting!

(In reply to Yaron from comment #0)

Regardless, I don't understand why the button should be transformed.
In Windows programs (e.g. Notepad) the top "window" in that button is on the left.

The button is actually already transformed:
https://searchfox.org/mozilla-central/rev/6dc530332ceb86c9d196c1afe8ba5c90c26be898/browser/themes/windows/browser.css#502
The problem is that after bug 1631278, the button is transformed twice, causing this issue.

Comment 2

[Itiel]

Attachment: Bug 1643935 - Don't re-mirror the restore button in full-screen mode on Windows 7 r?gijs

Comment 3

[Yaron]

Thank you Itiel. I appreciate it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0a1bf534329
Don't re-mirror the restore button in full-screen mode on Windows 7 r=Gijs

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1631278

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a0a1bf534329

Comment 7

[Yaron]

Thank you all.

Comment 8

[Itiel]

(In reply to Yaron from comment #7)

Thank you all.

Can you please verify this is fixed for you now on Nightly?

Comment 9

[Yaron]

(In reply to Itiel from comment #8)

Can you please verify this is fixed for you now on Nightly?

Yes, it is fixed on Nightly.

Thanks again.

Comment 10

[Itiel]

Comment on attachment 9154783 [details]
Bug 1643935 - Don't re-mirror the restore button in full-screen mode on Windows 7 r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: The Restore window control button is displayed incorrectly on RTL for Windows 7 users, when in full-screen mode.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only patch that targets Windows 7 only.
• String changes made/needed: None

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9154783 [details]
Bug 1643935 - Don't re-mirror the restore button in full-screen mode on Windows 7 r?gijs

approved for 78.0b6

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7643067c1eba

Comment 13

[Cristian Fogel [:cfogel]]

Updating flag based on reply from comment 9.