Closed
Bug 1643944
Opened 4 years ago
Closed 4 years ago
CacheIR: Optimize function.name
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: evilpie, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
We should optimize function.name when that property has not been resolved yet. Similar to what I did for the length property in bug 1332946. This happens around 500 times on reddit.
|
||
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Comment 1•4 years ago
|
||
name is non-nullptr if and only if the non-resolve hook fast-path was taken.
That means we can change if (!name) to use a simple else statement.
|
||
Updated•4 years ago
|
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
Optimise function.name similar to the existing function.length optimisation.
Depends on D90965
|
|
Assignee | |
Comment 3•4 years ago
|
||
Transpile LoadFunctionName using the same approach as taken for LoadFunctionLength.
Depends on D90966
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f10ebed59c7 Part 1: Use else-statement in finishBoundFunctionInit. r=evilpie https://hg.mozilla.org/integration/autoland/rev/4cda8cdf45cc Part 2: Optimise function.name in CacheIR. r=evilpie https://hg.mozilla.org/integration/autoland/rev/3ee21418fd0a Part 3: Transpile LoadFunctionName. r=evilpie
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6f10ebed59c7
https://hg.mozilla.org/mozilla-central/rev/4cda8cdf45cc
https://hg.mozilla.org/mozilla-central/rev/3ee21418fd0a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•