1643964 - CSP/XFO error pages' option to visit the page directly talks about opening in new window, should be tab instead

Status: NEW

(Firefox :: Security, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 79.0a1 + 78.0b3, Windows 8.1

Steps to reproduce based on bug 1461195:

• Go to https://johann-hofmann.com/frame-tester.html
• Enter https://google.com into the input field to get the error for X-Frame options

Text reads:

Nightly Can’t Open This Page

To protect your security, www.google.com will not allow Nightly to display the page if another site has embedded it. To see this page, you need to open it in a new window.

[Open Site in New Window]

The button will open it in a new tab - the text needs to get updated.

Comment 1

[Johann Hofmann [:johannh]]

Huh, I thought that we were saying "open in new window" in other places of the code, even when browser.link.open_newwindow is set to open in tabs, but you're probably right that it's preferable to use the correct term here. We need to alternate the string between "new window" and "new tab" depending on whether browser.link.open_newwindow is set. AFAIK we're opening this link in-content on purpose to avoid samesite leakage, so it will follow that pref.

Betsy, do you agree that's a good idea?

Comment 2

[Betsy Mikel [:betsymi]]

Are you asking if the button copy should read [Open Site in New Tab] ?

Comment 3

[Johann Hofmann [:johannh]]

I'd just like to confirm that we can say [Open Site in New Tab] when it will open in a tab and [Open Site in New Window] if it opens in a new window.

Comment 4

[Betsy Mikel [:betsymi]]

(In reply to Johann Hofmann [:johannh] from comment #3)

I'd just like to confirm that we can say [Open Site in New Tab] when it will open in a tab and [Open Site in New Window] if it opens in a new window.

Yes, we're good with that.