1644009 - Split direct task dispatching from AbstractThread

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Jean-Yves Avenard [:jya]]

Currently to be able to use direct tasks, which ar similar to the JS Promise microtasks, we need an AbstractThread and its tail dispatcher.

This is an implementation detail that doesn't have to be.

So the plan is to split direct task dispatching from the tail dispatcher and abstract thread.

We will do so with a new nsIDirectTaskDispatcher task.

nsThread and TaskQueue will then implement it.

Comment 1

[Jean-Yves Avenard [:jya]]

For this to be usable with MozPromise (which may require direct task dispatching), we need bug 1637500 to be resolved.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P1. Revert "Bug 1592488 - P11. Ensure an AbstractThread exists for each WorkerThread." r=baku

DirectTask dispatching will now be directly handled by nsThread.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P2. Revert "Bug 1592488 - P9. Make a DOMCacheThread an AbstractThread." r=baku

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79085

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P3. Revert "Bug 1592488 - P8. Ensure AbstractThread exists with STS thread." r=valentin

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79086

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P4. Revert "Bug 1592488 - P7. Ensure an AbstractThread exists with RemoteDecoder manager thread." r=mattwoodrow

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79087

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P5. Revert "Bug 1592488 - P6. Ensure an AbstractThread exists with RemoteWorkerService thread." r=nika

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79088

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P6. Revert "Bug 1592488 - P5. Ensure an AbstractThread exists with BackgroundThread." r=nika

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79089

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P7. Revert "Bug 1592488 - P4. Ensure an AbstractThread exists for the Compositor Thread." r=mattwoodrow

DirectTask dispatching will now be directly handled by nsThread.

Depends on D79090

Comment 9

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P8. Add SimpleTaskQueue object. r?froydnj

We will use it later for implementing direct task dispatching where required.

Depends on D79091

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P9. Add nsIDirectTaskDispatcher interface. r?froydnj

We extract the dealing of direct tasks from the TailDispatcher object and move into to the existing nsThread and TaskQueue classes.
TaskQueue is made to work with do_QueryInterface.

We continue accessing the direct tasks dispatcher via the TailDispatcher for now, which itself will forward the dealing of such tasks to the underlying thread.

Depends on D79092

Comment 11

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P10. Make MozPromise access direct task dispatcher using QI(nsIDirectTaskDispatcher). r?bholley

Depends on D79093

Comment 12

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P11. Make DocGroup's LabellingEventTarget implement nsIDirectTaskDispatcher. r?farre

It will simply forward the interface to the main thread.
This is the final step required to remove AbstractThread support here.

Depends on D79094

Comment 13

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P13. Don't have AutoTaskGuard inherit from AutoTaskDispatcher. r?bholley.

This prevent being able to assert in the AutoTaskDispatcher that we are using it from the right thread/taskqueue as the SimpleTaskQueue object isn't thread-safe.

We want to assert that all nsIDirectTaskDispatcher methods are only ever accessed on the underlying thread. To do so require that the scope of AutoTaskDispatcher to terminate prior the AutoTaskGuard one.

Depends on D79095

Comment 14

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P14. Fallback to normal dispatch on release. r?bholley

Depends on D79096

Comment 15

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1644009 - P12. Make STS thread supports nsIDirectTaskDispatcher interface. r?valentin

Depends on D79095

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50563df7052a
P1. Revert "Bug 1592488 - P11. Ensure an AbstractThread exists for each WorkerThread." r=nika
https://hg.mozilla.org/integration/autoland/rev/70208fbe3755
P2. Revert "Bug 1592488 - P9. Make a DOMCacheThread an AbstractThread." r=nika
https://hg.mozilla.org/integration/autoland/rev/12725e7040d6
P3. Revert "Bug 1592488 - P8. Ensure AbstractThread exists with STS thread." r=valentin,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/28097e44c058
P4. Revert "Bug 1592488 - P7. Ensure an AbstractThread exists with RemoteDecoder manager thread." r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/62b9fb746823
P5. Revert "Bug 1592488 - P6. Ensure an AbstractThread exists with RemoteWorkerService thread." r=nika
https://hg.mozilla.org/integration/autoland/rev/4dbb4af6a2ab
P6. Revert "Bug 1592488 - P5. Ensure an AbstractThread exists with BackgroundThread." r=nika
https://hg.mozilla.org/integration/autoland/rev/81a565d1fd64
P7. Revert "Bug 1592488 - P4. Ensure an AbstractThread exists for the Compositor Thread." r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/f6fc16f49976
P8. Add SimpleTaskQueue object. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/faa8e3461f33
P9. Add nsIDirectTaskDispatcher interface. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/a0fe9db3ab56
P10. Make MozPromise access direct task dispatcher using QI(nsIDirectTaskDispatcher). r=bholley
https://hg.mozilla.org/integration/autoland/rev/b7ed3455ea43
P11. Make DocGroup's LabellingEventTarget implement nsIDirectTaskDispatcher. r=farre
https://hg.mozilla.org/integration/autoland/rev/0888e8f9b191
P12. Make STS thread supports nsIDirectTaskDispatcher interface. r=valentin,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/d985d78962c7
P13. Don't have AutoTaskGuard  inherit from AutoTaskDispatcher. r=bholley.
https://hg.mozilla.org/integration/autoland/rev/86419b2114e5
P14. Fallback to normal dispatch on release. r=bholley

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/50563df7052a
https://hg.mozilla.org/mozilla-central/rev/70208fbe3755
https://hg.mozilla.org/mozilla-central/rev/12725e7040d6
https://hg.mozilla.org/mozilla-central/rev/28097e44c058
https://hg.mozilla.org/mozilla-central/rev/62b9fb746823
https://hg.mozilla.org/mozilla-central/rev/4dbb4af6a2ab
https://hg.mozilla.org/mozilla-central/rev/81a565d1fd64
https://hg.mozilla.org/mozilla-central/rev/f6fc16f49976
https://hg.mozilla.org/mozilla-central/rev/faa8e3461f33
https://hg.mozilla.org/mozilla-central/rev/a0fe9db3ab56
https://hg.mozilla.org/mozilla-central/rev/b7ed3455ea43
https://hg.mozilla.org/mozilla-central/rev/0888e8f9b191
https://hg.mozilla.org/mozilla-central/rev/d985d78962c7
https://hg.mozilla.org/mozilla-central/rev/86419b2114e5