1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

In Append, Assign, and Replace called with a substring_tuple_type argument, the tuple tree is traversed twice to determine the tuple length and whether the tuple depends on the buffer of the target substring. Both properties can be determined in a single go.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Append. r=#xpcom-reviewers

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Assign. r=#xpcom-reviewers

Depends on D78693

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Replace. r=#xpcom-reviewers

Depends on D78694

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/338bd5525594
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Append. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/8d78185301f1
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Assign. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/954c49edcc76
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Replace. r=froydnj

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for mochitest asan failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=954c49edcc7627faf941e273c88143a29c55ebbb&tochange=f54f65e5c5b4f0089ebc942ba9552b61e99e1c24&searchStr=asan%2Cmochitest&selectedTaskRun=dAuxSV6sRzu8MQRlF9AJVQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=306743717&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f54f65e5c5b4f0089ebc942ba9552b61e99e1c24

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e48f3461fa1
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Append. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/be540a7e5c81
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Assign. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/d5a00352bfba
Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Replace. r=froydnj

Comment 7

[Cosmin Sabou [:CosminS]]

Relanded this as the failure was actually Bug 1645415. Sorry for the trouble.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1e48f3461fa1
https://hg.mozilla.org/mozilla-central/rev/be540a7e5c81
https://hg.mozilla.org/mozilla-central/rev/d5a00352bfba