Closed Bug 1644224 Opened 4 years ago Closed 4 years ago

tsan complains that nsTimerEvent::sCanDeleteAllocator is racy

Categories

(Core :: XPCOM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

Attachments

(2 files)

Attached file tsan-failure.txt

Encountered the attached tsan failure when attempting to land bug 1630434. nsTimerEvent::sCanDeleteAllocator has no thread coordination, so tsan complains. Since nsTimerEvent::sAllocatorUsers is atomic/sequentially consistent, it seems like it wouldn't be that big of a deal to make sCanDeleteAllocator also atomic/sequentially consistent.

Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81a515561329
make nsTimerEvent::sCanDeleteAllocator atomic/sequentially consistent r=froydnj
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: