1644304 - WorkerPrivate::RunLoopNeverRan needs to notify and clear weak worker references so PerformanceStorageWorker doesn't leak

Status: RESOLVED DUPLICATE of bug 1714228

(Core :: DOM: Workers, defect, P2)

Description

[Andrew Sutherland [:asuth] (he/him)]

WorkerPrivate::RunLoopNeverRan() needs to notify and clear the WeakWorkerRef obtained by the PerformanceStorageWorker created in WorkerThreadPrimaryRunnable::Run by a call to EnsurePerformanceStorage that, out of threading necessity, is called before the call to BackgroundChild::GetOrCreateForCurrentThread() that can absolutely fail. See https://bugzilla.mozilla.org/show_bug.cgi?id=1638027#c39 for some extra context.

Comment 1

[Jens Stutte [:jstutte]]

Hi Eden, you might be interested to look at this? Any relation to bug 1749068 ?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Disclaimer: We've made some other changes to the performance object's lifecycle since then, I think, so it's possible this is moot or the situation has changed.

Comment 3

[Eden Chuang[:edenchuang]]

https://searchfox.org/mozilla-central/rev/840881e1232f664a58b39caaae6284c7bcf121df/dom/workers/WorkerPrivate.cpp#2956

The notification has already been done. Olli did it on bug 1714228.