1644308 - [wpt-sync] Sync PR 24050 - Fix issues with declarative shadow dom <template> during parsing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24050 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24050
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Fix issues with declarative shadow dom <template> during parsing

Prior to this CL, a "failed" \<template shadowroot> element would be
left marked as a declarative shadow root, even though it was just an
ordinary template. One example of this is:

\<video>
\<template shadowroot=open>\</template>
\</video>

Here, since the video element does not support shadow roots, the
template would be left in, but still marked as a declarative shadow
root. This would cause problems later if, for example,
template.innerHTML was called, because the content property is
protected for declarative shadow roots. Additionally, it was
previously impossible to access innerHTML on valid declarative
shadow root \<template> elements. Both of these have now been fixed,
and tests written.

Fixed: 1087457
Change-Id: Ia14c868e9e918e24c756b24ace69b8bb944d0b65

Reviewed-on: https://chromium-review.googlesource.com/2236890
WPT-Export-Revision: 76720f8ff219fc2c22d90a0a35909c3e5e82ac8a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e02a06aeba3e8afc97263de69e9c228026fc113

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 1
FAIL : 1

Chrome

CRASH: 2

Safari

OK : 2
PASS : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/declarative/innerhtml-before-closing-tag.html
Declarative Shadow DOM: innerHTML should work while parsing declarative shadow root <template>: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80e3fda313be
[wpt PR 24050] - Fix issues with declarative shadow dom <template> during parsing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9ca5b5920dd0
[wpt PR 24050] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/80e3fda313be
https://hg.mozilla.org/mozilla-central/rev/9ca5b5920dd0