1644337 - Date Picker UI by <input type=date> in unexpected position with Fission

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: screenshot with fission

Environment

macOS 10.15.4
Firefox Nightly 79 2020-06-08

Step

1. fission.autostart=true, then restart
2. Browse https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input
3. Set focus to <input type=date>'s control
4. Click yyyy

Result

Date picker UI is top-left in content window

Expected Result

Date picker UI should be bottom of <input type=date>. Of course, if without fission, this doesn't occur.

Comment 1

[Chris Peterson [:cpeterson]]

Sending this Fission Date Picker bug to Layout triage. This bug blocks enabling Fission in Nightly.

I can also reproduce this bug on Windows 10.

Comment 2

[Chris Peterson [:cpeterson]]

The color picker UI has the same positioning bug as the date picker.

Here is a color picker test case: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color

Comment 3

[Hiroyuki Ikezoe (:hiro)]

On my linux box, the color picker window is positioned at the center of the browser window.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Chris, can you please open a new bug for the color picker issue you are seeing? Maybe it's a different issue I am going to move the date picker issue into Toolkit.

So, I think a problem here in DateTimePickerChild.jsm, BrowserUtils.getElementBoundingRect probably doesn't work in fission world. Probably GeometryUtils.getBoxQuadsFromWindowOrigin can be used (But we might wand to add a new ChromeOnly API for the date picker or some such).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)

Chris, can you please open a new bug for the color picker issue you are seeing? Maybe it's a different issue I am going to move the date picker issue into Toolkit.

I filed new bug 1647583 for the color picker issue. Turns out it's an existing bug and not a Fission bug. :)

Comment 7

[Matthew N. [:MattN]]

The Date/Time picker is outside the scope of Form Manager. I probably would have left this in "Layout: Form Controls" but I guess it is the front-end team that has been touching this most recently.

Comment 8

[Neha Kochar [:neha]]

Mike, is this something you could look into or know who should?

Comment 9

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

I suspect this will have the same underlying cause as the misplaced <select> dropdown, which we solved. Perhaps Neil has time to look at this?

Comment 10

[Neil Deakin]

Attachment: Bug 1644337, add an isAnchored property to popups, as popups can be anchored to a rectangle as well as a node. This prevented the arrow from appearing in panels, r=tnikkel

Comment 11

[Neil Deakin]

Attachment: Bug 1644337, anchor the date time picker dropdown panel to a screen rectangle, as a node will not be available for out of process iframes, r=ntim

Depends on D86099

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fb094f206b3
add an isAnchored property to popups, as popups can be anchored to a rectangle as well as a node. This prevented the arrow from appearing in panels, r=smaug
https://hg.mozilla.org/integration/autoland/rev/3bdd93319474
anchor the date time picker dropdown panel to a screen rectangle, as a node will not be available for out of process iframes, r=ntim

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9fb094f206b3
https://hg.mozilla.org/mozilla-central/rev/3bdd93319474