1644393 - Perma js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti") [0.0 s] when Gecko 79 merges to Beta on 2020-06-29

Status: VERIFIED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=f-PQE2F3Qha6yIka1e2TRQ-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=09ee4be5cc8391808c4f6c132a9733bfb2d9c99f

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=305597199&repo=try

TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti --ion-eager --ion-offthread-compile=off --more-compartments") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti --baseline-eager") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti --no-blinterp --no-baseline --no-ion --more-compartments") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/bug-1643913.js | Error: Invalid long option: --no-ti (code 1, args "--enable-weak-refs --no-ti --blinterp-eager") [0.0 s]

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1644393 - Skip test where --no-ti option is not available r?sfink

I don't know why this test case depends on disabling TI, but it doesn't work without it. That shell option is only supported on nightly however, presumably to avoid the overhead of checking the flag all the time.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The patch doesn't fix the issue.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1644393 - Fix test case to work in beta/release builds r?sfink

I rewrote the test to be much more specific, and it took a good bit of fiddling about to come up with something that worked.

I had to add a way of making gcslice only trigger a slice during an incremental collection, otherwise this can end up looping forever.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd70b0fa849
Fix test case to work in beta/release builds r=sfink

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cbd70b0fa849

Comment 6

[Alexandru Michis [:malexandru]]

Verified fixed in today's central-as-beta simulations:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52c8ccce318257d20291ef15e4b07eb667d5d6f8&searchStr=sm&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=6fce1854cf85004b1cf46ec1983a9cac12478942&searchStr=sm