Closed Bug 1644424 Opened 10 months ago Closed 10 months ago

Constant fold SIMD reduction operators

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Constant fold all_true, any_true, bitmask, and extract_lane operators. On at least one occasion I've observed emcc at even -O3 emit code that's not properly folded, and it costs us little to do this.

In general, we should do constant folding as other optimizations may result
in constants to fold. In addition, emcc has been observed not to fold
SIMD constants in all desirable cases.

Inserts logging (active in DEBUG builds) and adds test cases that check that
the constant folding is triggered in at least trivial cases, cf other
test cases in the same test file.

Attachment #9155268 - Attachment description: Bug 1644424 - Constant fold wasm SIMD reductions. r?jseward → Bug 1644424 - Constant fold wasm SIMD reductions. r=jseward
Attachment #9155329 - Attachment description: Bug 1644424 - Report triggering of SIMD constant folding. r?jseward → Bug 1644424 - Report triggering of SIMD constant folding. r=jseward
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83605fde62ee
Constant fold wasm SIMD reductions. r=jseward
https://hg.mozilla.org/integration/autoland/rev/3ce9af6580b2
Report triggering of SIMD constant folding. r=jseward
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Regressions: 1646776
No longer regressions: 1646776
You need to log in before you can comment on or make changes to this bug.