1644452 - mozilla::dom::DOMArena::Release() should be called on the main thread instead of from ~DocGroup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Andreas Farre [:farre]]

DOMArena isn't thread safe, but DocGroup is and hence DOMArena needs to be release on the main thread in the case where DocGroup is destroyed off main thread. This causes assertions like:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304507291&repo=autoland&lineNumber=6743-6800

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1644452 - Release DocGroup::mArena on the DocGroup's event target. r=smaug

Comment 2

[Andreas Farre [:farre]]

Comment on attachment 9155289 [details]
Bug 1644452 - Release DocGroup::mArena on the DocGroup's event target. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: Buggy behaviour
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c1d5a016149
Release DocGroup::mArena on the DocGroup's event target. r=smaug

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3c1d5a016149

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9155289 [details]
Bug 1644452 - Release DocGroup::mArena on the DocGroup's event target. r=smaug

Correctness fix for a bug causing assertion failures. Approved for 78.0b6.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63ced6523e52