1644472 - Optimize some RegExp intrinsics in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

I have some patches for IsRegExpObject and RegExp{Matcher,Searcher,Tester} that improve Warp perf on octane-regexp.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1644472 part 1 - Optimize IsRegExpObject intrinsic in CacheIR and Warp. r?evilpie!

I tried to keep this generic in case we add a similar function for another Class
in the future.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1644472 part 2 - Optimize RegExpMatcher, RegExpSearcher, RegExpTester intrinsics in CacheIR and Warp. r?iain!

The CacheIR code is just a VM call that's slightly faster than the CallNative path.
The main benefit is that this lets Warp use the optimized regexp stubs.

At some point it would be nice to call the same code stubs from CacheIR.

Depends on D79040

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1644472 part 3 - Optimize SubstringKernel intrinsic in CacheIR and Warp. r?evilpie!

Depends on D79041

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1644472 part 4 - Optimize RegExpPrototypeOptimizable and RegExpInstanceOptimizable intrinsics. r?iain!

These just do a Shape guard against a Shape stored in the Realm. If the guard
fails we do a callWithABI to a function that updates the shape.

Depends on D79263

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5845925ecf9
part 1 - Optimize IsRegExpObject intrinsic in CacheIR and Warp. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/f5d92b5d503e
part 2 - Optimize RegExpMatcher, RegExpSearcher, RegExpTester intrinsics in CacheIR and Warp. r=iain

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a5845925ecf9
https://hg.mozilla.org/mozilla-central/rev/f5d92b5d503e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fb53405c05
part 3 - Optimize SubstringKernel intrinsic in CacheIR and Warp. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/798a5cd87e54
part 4 - Optimize RegExpPrototypeOptimizable and RegExpInstanceOptimizable intrinsics. r=iain

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/57fb53405c05
https://hg.mozilla.org/mozilla-central/rev/798a5cd87e54