1644477 - Candidate pair insertion code has readability issues

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P3)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1644477: Make candidate pair insertion code easier to read/understand. r?mjf

Includes removing an error code for a function that never fails, and removing
an error return when the function successfully did what it said it would.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5cd529bce4a1eb49f1566ff40e86820b1672029

Gtest: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f28ab37e399507f969b0c65f6e83d2551843e26

Comment 3

[Byron Campen [:bwc]]

Try looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45c61fd0206e
Make candidate pair insertion code easier to read/understand. r=mjf

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/45c61fd0206e

Comment 6

[Byron Campen [:bwc]]

Comment on attachment 9155331 [details]
Bug 1644477: Make candidate pair insertion code easier to read/understand. r?mjf

Beta/Release Uplift Approval Request

• User impact if declined:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: None

Comment 7

[Byron Campen [:bwc]]

Comment on attachment 9155331 [details]
Bug 1644477: Make candidate pair insertion code easier to read/understand. r?mjf

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined:
• Fix Landed on Version: 79
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String or UUID changes made by this patch: None

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9155331 [details]
Bug 1644477: Make candidate pair insertion code easier to read/understand. r?mjf

approved for 78.0b8 and 68.10esr

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/d4a82cd66cca

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/230886f7aa87