1644478 - Data Race when setting priority for TRR service channel

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Attachment: datarace_stacl..txt

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305569607&repo=try&lineNumber=3689

It seems that we have a data race when setting a higher priority for the TRRService channel.

I assume the fix would be to make the priority Atomic.

Since the increased priority didn't actually fix the TRR performance issue should we also remove this code ?

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1644478 - Make nsPipeInputStream::mPriority Atomic r=mayhemer

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1644478 - Don't increase priority for TRR service channel r=mayhemer

This was done before using a different thread for the TRR channel
and it didn't actually make a difference in performance, so
maybe we should remove this code.

Depends on D78938

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d26c935c177
Make nsPipeInputStream::mPriority Atomic r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/2ddc1c822b05
Don't increase priority for TRR service channel r=mayhemer,necko-reviewers

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0d26c935c177
https://hg.mozilla.org/mozilla-central/rev/2ddc1c822b05