Closed Bug 1644515 Opened 4 years ago Closed 4 years ago

Re-enable test for search counts across sessions

Categories

(Toolkit :: Telemetry, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: raphael, Assigned: b4hand)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

We have been seeing an increase of intermittent failures for test_search_counts_across_sessions.py which verifies that searches are recorded in Firefox Telemetry (bug 1589297). We were unable to identify the source of the intermittent failures up until now. As a result, it was disabled by our Code Sheriff team.

Assignee: nobody → bforehand
Status: NEW → ASSIGNED

May also be asked to repoint SEARCH_COUNT's ownership from loines@ to mmccorquodale@ (see bug 1589297 comment#60)

Henrik, in the bug Raphael linked above you mentioned this: To await the page finished loading you could use WebDriver:ExecuteAsyncScript and wait for the former page to be unloaded, and the readyState of the new document to be complete.

I tried just printing document.readyState while the page was loading and it seemed to show "complete" multiple times, and usually before the page was actually loaded. It also doesn't seem like document.readyState is an async function but I am just getting that from trying it in the browsers web console.

Could you provide an example of what you advised we should do? I know the document.readyState has a few different return values but it doesn't seem to be too reliable. Of course I could be doing something wrong here.

Flags: needinfo?(hskupin)

Note that I don't know which URL you are talking about and if there are also iframes included in target page. Nevertheless you can get multiple load events or ready states depending on the document / URL. So in fact you want to not only check document.readyState but also document.location if it is the page you are expecting. Otherwise I miss data of what this test is actually doing, and how it should behave.

Flags: needinfo?(hskupin)
Pushed by rpierzina@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63ebbe6a678c
Enable search tests with fixes; r=raphael,chutten
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5adb40760bcd
Fix lint failure in telemetry_harness/testcase.py a=lint-fix
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: