Closed Bug 1644570 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 24071 - Revert "webauthn: implement getPublicKey() and friends."

Categories

(Core :: DOM: Web Authentication, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24071 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24071
Details from upstream follow.

Pavel Yatsuk <pavely@chromium.org> wrote:

Revert "webauthn: implement getPublicKey() and friends."

This reverts commit c5d236776cd30849a65ca626e51cd19e651da7c6.

Reason for revert: I suspect that this CL causes Fido2CredentialRequestTest failures on android-pie-x86-rel:
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel

Here is a snippet of callstack:
java.lang.AssertionError: expected:\<11> but was:\<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.chromium.chrome.browser.webauth.Fido2CredentialRequestTest.testMakeCredential_attestationIndirect(Fido2CredentialRequestTest.java:921)

Here is sample failure:
https://00e9e64bac4dbda9c3b8a07931c85e48f4420a03929ffbcaf5-apidata.googleusercontent.com/download/storage/v1/b/chromium-result-details/o/html%2Fchrome_public_test_apk_android-pie-x86-rel_990_2020_06_09_T16_33_45-UTC?qk=AD5uMEvQvMK8K2ZyV-tHIDwdTtLEnQK-X1Mw0ohWLQeOpgogj0sVgm_7y9e5CdF-FMV6ObBmwjpVxD6Jh8_7VTv4z2FpOutuS8Gd6qQH5OxikfytS8cKFb_SRCCQXIgWq45BwD7DediOcKTF-UZea_JAoFuHO0ljO0PRqnkFYSoIHcPONuqaszXChp63b5o4VAKYsofAHDhpHru_hiAf6xUyfK91I8cr-2sdHjQU6Ks4XQIIWVnq2PSAiysd6hNeq51qWPEaX7HS8hCwWIpe55Xq9hIWLOtab3MY1WLLxM3UuWMY8IDCKfcvnrTiQMcRyeD7Iii33jHhC8-rDGttfDEl39kpFnWynDC-C0TmPFoCJVkl7mHxz0uCNlQJ3I0Rt_F2DTqA96qIKrpwEltNs96-0j1VgSOJCjU3s4od6h7juoIxpH5HThyg7G-fB1-MWzv7mQfAE5ZBilodU0CKMsFrnN_5Kf4thAbDj-RJUiUNpy0A9swLOhMLjEsfxQeDRldVvy9OVUNvcakhJziml5iA7LWoDB58E3eGTyUi-dA5aOLN3KWLR7T452j4MwnCHC5vTRNxxGxCkemgQQDkl1fHJas1u6GUcY4_ncvhIuGvLsfg8uqWpzFuau4CFamGC2USpyVpNIeNhpcf2w-lYzG1rkHjHWYgUKSvhoaItY3oeRFjnkYMgZrDsy8QmneuVVGTPd4nzoWWaCZbaG9ZaF80xRu9YhYnTUXI7GqQF1rlst09Mqu8IvDXo9dgYzodInIA6p3H7azZgnvCfzYUxL4QVrvskyjTQCITmz-o2W6CPUzBqWJhWLRTpZYcVSV7z8zjj1cFwDQPBKpJzQDRrtC1sZCM0WrmQ7oSNeU-AH3uBaNWeGBF2rkY8-9gx8dlr38DGQvXoKZVWHWi61jVnQhac27ctKBLKQ&isca=1

Original change's description:

webauthn: implement getPublicKey() and friends.

This change implements the getPublicKey(), getPublicKeyAlgorithm(), and
getAuthenticatorData() functions described in the editor's draft of
WebAuthn level two[1].

[1] https://w3c.github.io/webauthn/#sctn-public-key-easy

BUG=1083301

Change-Id: I3a03279d5239a9f8df50a78f2166f30d01d38d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204087
Reviewed-by: Andrew Grieve \<agrieve@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Reviewed-by: Alex Russell \<slightlyoff@chromium.org>
Reviewed-by: Jared Saul \<jsaul@google.com>
Reviewed-by: Adam Langley \<agl@chromium.org>
Reviewed-by: Nina Satragno \<nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer \<martinkr@google.com>
Commit-Queue: Adam Langley \<agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776517}

TBR=kenrb@chromium.org,agl@chromium.org,slightlyoff@chromium.org,nsatragno@chromium.org,agrieve@chromium.org,jsaul@google.com,martinkr@google.com

Change-Id: I7429b5b7ecd7fa38c4e1ec2905b80a15e7c64216
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1083301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238749
Reviewed-by: Pavel Yatsuk \<pavely@chromium.org>
Commit-Queue: Pavel Yatsuk \<pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776637}

PR 24071 applied with additional changes from upstream: 4e76cd0bf9cfd78281ebb5348efbde109a3f965e
Component: web-platform-tests → DOM: Web Authentication
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 2
NOTRUN : 2

Chrome

OK : 1
PASS : 4

Safari

FAIL : 1
TIMEOUT: 2
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webauthn/webauthn-testdriver-basic.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
Get an assertion: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Create a credential: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Clean up the test environment: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Set up the test environment: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webauthn/webauthn-testdriver-basic.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/289c45637896
[wpt PR 24071] - Revert "webauthn: implement getPublicKey() and friends.", a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.