1644600 - SharedArrayRawBufferRefs is not exported

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

Reported on the mailing list. SharedArrayRawBufferRefs is not marked JS_PUBLIC_API but is a member of JSStructuredCloneData which is JS_PUBLIC_API.

Comment 1

[bellaz89]

This defect prevents external embedders to use Spidermonkey C++ StructuredClone API. Observed since ESR version 60.

Comment 2

[wraitii]

This is still bugged in SM78. It'd be good to fix it for the next ESR - we currently have to ask distributions to apply this patch, which is rather annoying.

Comment 3

[Marco Trevisan (Treviño)]

I can confirm this is still the case, the only workaround is leaking right now...

Comment 4

[Marco Trevisan (Treviño)]

Attachment: Bug 1644600 - Move JSStructuredCloneData destructor into private impl r?sfink

This is used by StructuredClone and if it is not exported it's not
possible to get linking done.

JSStructuredCloneData::~JSStructuredCloneData()':
/usr/include/mozjs-78/js/StructuredClone.h:459:
undefined reference to
`js::SharedArrayRawBufferRefs::~SharedArrayRawBufferRefs()

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a32d15411ed3
Move JSStructuredCloneData destructor into private impl r=sfink

Comment 6

[Marco Trevisan (Treviño)]

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch makes possible that a public API is usable by embedders
• User impact if declined: No impact to Firefox. Embedders will need to wait for the next ESR upgrade if they want to use JSStructuredCloneData API.
• Fix Landed on Version: 90
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk because it won't change anything for Firefox
• String or UUID changes made by this patch: None

Comment 7

[Marco Trevisan (Treviño)]

Comment on attachment 9219903 [details]
Bug 1644600 - Move JSStructuredCloneData destructor into private impl r?sfink

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String or UUID changes made by this patch:

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a32d15411ed3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9219903 [details]
Bug 1644600 - Move JSStructuredCloneData destructor into private impl r?sfink

Approved for 78.11esr. I guess we're not worried about uplifting to Beta for Fx89 since this only affects SM embedders anyway.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/2abc0a4645aa