Closed Bug 1644614 Opened 4 months ago Closed 4 months ago

Improve margins around site tiles in onboard screen

Categories

(Firefox :: Messaging System, enhancement, P1)

79 Branch
Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
Firefox 79
Iteration:
79.2 - June 15 - June 28
Tracking Status
firefox79 --- verified

People

(Reporter: mwalkington, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

To improve scannability, add space above and below the site tiles. Aaron, can you please provide specs for this?

Flags: needinfo?(abenson)

Yep, change the following:

div.welcome-text {margin-bottom:30px}
button.primary{margin-top:30px}

Flags: needinfo?(abenson)
Assignee: nobody → pdahiya
Iteration: --- → 79.2 - June 15 - June 28
Priority: -- → P1
Attached image Screenshot GetStarted

NI Aaron for UI review of above Get Started and Import Settings screens with margin fixed. Thanks!

Flags: needinfo?(abenson)

Looks good to me!

Flags: needinfo?(abenson)
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f312d3e8d86d
Fix margin around tiles r=emcminn
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

I have verified that the "div.welcome-text" bottom margin is 30px and that the "button.primary" top margin is 30px using Firefox Nightly 79.0a1 (Build ID: 20200622214758) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.