Closed Bug 1644616 Opened 5 years ago Closed 5 years ago

Control line break for header on import onboarding screen

Categories

(Firefox :: Messaging System, enhancement, P1)

79 Branch
Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Status
firefox78 --- verified
firefox79 --- verified

People

(Reporter: meridel, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached image Import page.png

To balance the import page, the header should break after "passwords":

Import your passwords,
bookmarks, and more

One solution would be to make the line break part of the string ( i.e. <br/> ) for the En-locale for the experiment. Alternatively, Ed suggested that we use non-breaking spaces and it sounds like that will work.

To note, if we go ahead with this page as part of default onboarding, here is the recommendation (from content strategy and l10n) for how to handle this for other locales: the community can test and set custom line breaks if needed. This customization work won’t be on the devs. Prioritize tier 1 locales.

Marking issue as resolved as the fix containing updated content is deployed via Remote Settings for 78 and 79 experiments and need not ride release trains.

https://github.com/mozilla/messaging-system-inflight-assets/commit/c3b71f25b4a4c3cd9b8430cf99f13561aa25429c#diff-f86e701d864322743917bbb731197556R415

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → pdahiya
Iteration: --- → 79.1 - June 1 - June 14
Priority: -- → P1
Regressions: 1645043
Target Milestone: --- → Firefox 79

I have verified that the line breaks after the "passwords" word from the "about:welcome" page's header.

Verified using the latest Firefox Beta (78.0b9 Build ID - 20200619002543) and the latest Firefox Nightly (79.0a1 Build ID - 20200621093846) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: