1644655 - Fix template release-notes.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[ddenoncin]

Attachment: bugzilla-5.0.6-template.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

Execute perl -I. t/009bugwords.t

Actual results:

not ok 147 - template/en/default/pages/release-notes.html.tmpl contains invalid bare words (e.g. 'bug') --WARNING

Expected results:

ok 147 - template/en/default/pages/release-notes.html.tmpl has no invalid barewords

Comment 1

[Dave Miller [:justdave]]

Confirming bug.
This affects only the 5.2 branch (5.0.x > 5.0.4 became that) and will be a release blocker for 5.2

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 9155527 [details] [diff] [review]
bugzilla-5.0.6-template.patch

On the one hand, I don't think this patch is the correct way to fix it. We don't want the configured word for bug to replace here, we always want that to say "bug" because that's what we use on Bugzilla's own bug tracker (this site). On the other hand, it's already done that way in the rest of the file. Meh. Long term we should probably make an exception for this file. For now, this patch will do.

Comment 3

[Dave Miller [:justdave]]

Committing this will need to hold until the PRs on Bug 1785938 get merged.

Comment 4

[Dave Miller [:justdave]]

Attachment: GitHub Pull Request

Comment 5

[Dave Miller [:justdave]]

justdave merged commit 9299f43 into 5.2