1644658 - Remove usages of loadstart & loadend events in screenshots code

Status: RESOLVED FIXED

(Firefox :: Headless, task)

Description

[Frederik Braun [:freddy]]

We want to unship loadstart and loadend for web compatibility in Bug 1574487.

We could just stop exposing it to content and keeping it chrome-only, but given the little amount of consumers, it would be best to completely remove the code.

This bug is about removing loadend/loadstart code in e.g.,

• https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/components/shell/test/test_headless_screenshot.html#93

Comment 1

[Robin Steuber (they/them) [:bytesized]]

I'm going through all the untriaged bugs in my team's components. I don't know if this bug is still relevant, but I do know that it doesn't belong in Shell Integration. Despite the broad name, the Shell Integration component is only intended for bugs related to determining if Firefox is the default browser, setting Firefox as the default browser, and setting the desktop background.

Moving this to what I hope is a more appropriate component.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Anne, could you set proper priority/serverity?

Comment 3

[Anne (:annevk)]

This is a problem with Firefox, not Platform code. Moving it to Firefox General as I'm not sure what the correct component would be for the issue mentioned in comment 0.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This seems to be still an issue https://searchfox.org/mozilla-central/rev/bfa4dfd40b8fe6f1a6504e86b5ad2c5fd402bfc0/browser/components/shell/test/head.js#96-97
loadstart and loadend add quite a bit overhead because they effectively flood the main thread with simple tasks, so I'd like to remove them sooner than later.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1644658 - Remove usages of <img> loadend events in screenshots code, r=mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fe2c7526246
Remove usages of <img> loadend events in screenshots code, r=mconley

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_staticPartition_saveAs.js

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/029f79627075
Remove usages of <img> loadend events in screenshots code, r=mconley

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/029f79627075