Closed Bug 1644661 Opened 4 years ago Closed 1 year ago

Emit Runtime.executionContextsCleared event in Runtime.disable

Categories

(Remote Protocol :: CDP, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: whimboo, Assigned: canadahonk)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

Attachments

(1 obsolete file)

When the Runtime gets disabled we will have to clean-up the contexts and emit a Runtime.executionContextsCleared event appropriately.

Priority: -- → P3
Whiteboard: [puppeteer-beta2-mvp]
Component: CDP: Runtime → CDP

Also adds clean-up for each context, as wanted in the bug report. Plus
updates test added when fixing related Bug 1636384, and this diff
depends on the fix for that as it is based on it.

Depends on D166613

Assignee: nobody → oj
Status: NEW → ASSIGNED

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #2)

The review process is currently blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1407315.

As the discussion on that issue revealed this it not wanted. As such we can close this bug as invalid.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Attachment #9311865 - Attachment is obsolete: true
See Also: → 1636384
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: