1644694 - Do not call mozilla::dom::FallbackEncoding::FromLocale() in nsIndexedToHTML.cpp

Status: RESOLVED FIXED

(Core :: Networking: File, task, P2)

Description

[Henri Sivonen (:hsivonen)]

nsIndexedToHTML.cpp has this bit of code:

  // unescape may fail because
  // 1. file URL may be encoded in platform charset for backward compatibility
  // 2. query part may not be encoded in UTF-8 (see bug 261929)
  // so try the platform's default if this is file url
  if (NS_FAILED(rv) && uri->SchemeIs("file") && !NS_IsNativeUTF8()) {
    auto encoding = mozilla::dom::FallbackEncoding::FromLocale();
    nsAutoCString charset;
    encoding->Name(charset);
    rv = mTextToSubURI->UnEscapeAndConvert(charset, titleUri, unEscapeSpec);
  }

The only platform where NS_IsNativeUTF8() returns false is Windows, which supports both UTF-8 file; URLs and legacy "ANSI" codepage file: URLs. However, our own directory listing code appears to always generate UTF-8 file: URLs, so it should be OK to remove this block.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1644694 - Do not call mozilla::dom::FallbackEncoding::FromLocale() in nsIndexedToHTML.cpp.

Comment 2

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e34f424950c8cb316e70cb7c2b97ebfe5365463b

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a644e527a77f
Do not call mozilla::dom::FallbackEncoding::FromLocale() in nsIndexedToHTML.cpp. r=valentin

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a644e527a77f