1644743 - Consolidate Targeting in Desktop

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Tech Doc.
Right now there are several targeting environments in use:

• ClientEnvironment used by RemoteSettingsClient.jsm
• A different (normandy) ClientEnvironment used by Normandy*
• ASRouterTargeting used by the Messaging System

We need a new targeting environment (and maintain backwards compatibility) in order to add new (required) features around telemetry and logging for population estimation. This will replace Normandy but also be used by Exp Manager and other modules that need it.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1644743 - Consolidate Targeting evaluation across Normandy, Experiment Manager and ASRouter

Comment 2

[Andrei Oprea [:andreio]]

Attachment: data-review-1644743.txt

Comment 3

[Andrei Oprea [:andreio]]

Attachment: data-review-1644743.txt

Comment 4

[Chris H-C :chutten]

Comment on attachment 9165072 [details]
data-review-1644743.txt

PRELIMINARY NOTE:

There is a new version of the Data Review Request that should be used: https://github.com/mozilla/data-review/blob/master/request.md

The change between the version you used and the new version is an additional question (Q6) about where the documentation will live. In this case I know where it will live and address that information in my first answer.

For future reviews, please use the new request.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Andrei Oprea is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47420937d6b1
Consolidate Targeting evaluation across Normandy, Experiment Manager and ASRouter r=k88hudson,mythmon,janerik

Comment 6

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 47420937d6b1 (bug 1644743) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js

Backout: https://hg.mozilla.org/integration/autoland/rev/944f67781bcb6a0b90cb5b25c5b85fe3848998c2

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=47420937d6b10c4eeaa7af0ca26e6ac8f9e525cc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310967711&repo=autoland&lineNumber=2802

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ef572f2fd4
Consolidate Targeting evaluation across Normandy, Experiment Manager and ASRouter r=k88hudson,mythmon,janerik

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/41ef572f2fd4