1644762 - `Invalid argument supplied for foreach()` loading D28717

Status: NEW

(Conduit :: Phabricator, defect)

Description

[:glob ✱]

Visiting https://phabricator.services.mozilla.com/D28717 results in:

Encountered a processing exception, then another exception when trying to build a response for the first exception.
- RuntimeException: array_walk_recursive() expects parameter 1 to be array, null given
- RuntimeException: Invalid argument supplied for foreach()

Comment 1

[David Lawrence [:dkl]]

The error is not making it to Sentry but I was able to get some more info from the Google Stackdriver logs:

[10-Jun-2020 19:23:43 UTC] #0 <#4> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/differential/controller/DifferentialRevisionViewController.php:295]"
[10-Jun-2020 19:23:43 UTC] #1 <#4> DifferentialRevisionViewController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:289]"
[10-Jun-2020 19:23:43 UTC] #2 <#3> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/externals/extensions/sentry/sentry/src/ErrorHandler.php:379]"
[10-Jun-2020 19:23:43 UTC] #3 <#3> Sentry\ErrorHandler::handleError(integer, string, string, integer, array)"
[10-Jun-2020 19:23:43 UTC] #4 <#3> array_walk_recursive(NULL, Closure, string) called at [<moz-extensions>/logging/SentryLoggerPlugin.php:81]
[10-Jun-2020 19:23:43 UTC] #5 <#3> SentryLoggerPlugin::{closure}(Sentry\Event) called at [<phabricator>/externals/extensions/sentry/sentry/src/Client.php:186]
[10-Jun-2020 19:23:43 UTC] #6 <#3> Sentry\Client::prepareEvent(array, NULL) called at [<phabricator>/externals/extensions/sentry/sentry/src/Client.php:108]
[10-Jun-2020 19:23:43 UTC] #7 <#3> Sentry\Client::captureEvent(array, NULL) called at [<phabricator>/externals/extensions/sentry/sentry/src/Client.php:100]
[10-Jun-2020 19:23:43 UTC] #8 <#3> Sentry\Client::captureException(RuntimeException) called at [<moz-extensions>/logging/SentryLoggerPlugin.php:110]
[10-Jun-2020 19:23:43 UTC] #9 <#3> SentryLoggerPlugin::handleError(string, RuntimeException, array) called at [<arcanist>/src/error/PhutilErrorHandler.php:456]
[10-Jun-2020 19:23:43 UTC] #10 <#3> PhutilErrorHandler::dispatchErrorMessage(string, RuntimeException, array) called at [<arcanist>/src/error/phlog.php:36]
[10-Jun-2020 19:23:43 UTC] #11 <#3> phlog(RuntimeException) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
[10-Jun-2020 19:23:43 UTC] #12 <#3> PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:753]"
[10-Jun-2020 19:23:43 UTC] #13 <#3> AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:301]"
[10-Jun-2020 19:23:43 UTC] #14 <#2> AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:209]"
[10-Jun-2020 19:23:43 UTC] #15 <#2> AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]
[10-Jun-2020 19:23:43 UTC] #16 phlog(PhutilAggregateException) called at [<phabricator>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
[10-Jun-2020 19:23:43 UTC] #17 AphrontUnhandledExceptionResponse::setException(PhutilAggregateException) called at [<phabricator>/webroot/index.php:46]
[10-Jun-2020 19:23:43 UTC] Error handler was reentered, some errors were not passed to the listener.

Comment 2

[:glob ✱]

Attachment: revision json

Comment 3

[Zeid [:zeid]]

Do we have any idea how many revisions this is impacting, and why it is not showing up in Sentry?