1644789 - Perma devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js:24

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=305815079&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QIl2Xbs1T5CfvCoUtWkK5w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-06-10T15:40:53.127Z] 15:40:53 INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js
[task 2020-06-10T15:40:53.548Z] 15:40:53 INFO - GECKO(3074) | console.error: "Store does not have a valid reducer. Make sure the argument passed to combineReducers is an object whose values are reducers."
[task 2020-06-10T15:40:53.851Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-06-10T15:40:53.886Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-06-10T15:40:53.894Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-06-10T15:40:53.894Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-06-10T15:40:53.942Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2020-06-10T15:40:53.945Z] 15:40:53 INFO - GECKO(3074) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2020-06-10T15:40:53.982Z] 15:40:53 INFO - TEST-INFO | started process screentopng
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - TEST-INFO | screentopng: exit 0
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Buffered messages logged at 15:40:53
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Entering test bound
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,%0A%20%20%3Cstyle%20type%3D'text%2Fcss'%3E%0A%20%20%20%20%23flex%20%7B%0A%20%20%20%20%20%20display%3A%20flex%3B%0A%20%20%20%20%7D%0A%20%20%3C%2Fstyle%3E%0A%20%20%3Cdiv%20id%3D%22flex%22%3E%3C%2Fdiv%3E%0A
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Tab added and finished loading
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/inspector/rules/test/doc_frame_script.js
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Opening the inspector
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Opening the toolbox
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-06-10T15:40:54.231Z] 15:40:54 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-06-10T15:40:54.232Z] 15:40:54 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-06-10T15:40:54.233Z] 15:40:54 INFO - Toolbox opened and focused
[task 2020-06-10T15:40:54.234Z] 15:40:54 INFO - Selecting the node for '#flex'
[task 2020-06-10T15:40:54.235Z] 15:40:54 INFO - Buffered messages finished
[task 2020-06-10T15:40:54.238Z] 15:40:54 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js:24 - TypeError: can't access property "valueSpan", getRuleViewProperty(...) is undefined
[task 2020-06-10T15:40:54.239Z] 15:40:54 INFO - Stack trace:
[task 2020-06-10T15:40:54.240Z] 15:40:54 INFO - @chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_flexbox-highlighter-on-mutation.js:24:40
[task 2020-06-10T15:40:54.241Z] 15:40:54 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-06-10T15:40:54.242Z] 15:40:54 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-06-10T15:40:54.243Z] 15:40:54 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-06-10T15:40:54.244Z] 15:40:54 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-06-10T15:40:54.245Z] 15:40:54 INFO - Leaving test bound
[task 2020-06-10T15:40:54.248Z] 15:40:54 INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.jsm" line: 253}]
[task 2020-06-10T15:40:54.249Z] 15:40:54 INFO - GECKO(3074) | console.warn: "Inspector destroyed while executing onReflow callback"
[task 2020-06-10T15:40:54.250Z] 15:40:54 INFO - Removing tab.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This failed and the retrigger also: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=2148cea246618988ca0e4be17793b2622ce3e26f&selectedTaskRun=QIl2Xbs1T5CfvCoUtWkK5w-0

Julian. can you check this issue? Razvan is blocking requests at the moment.

Comment 2

[Razvan Caliman [:rcaliman]]

I'm still here. My personal account is blocking needinfo requests. My Mozilla one is open.
I'll put this in my queue to investigate.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 4

[Intermittent Failures Robot]

4 failures in 5211 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• mozilla-central: 1
• mozilla-beta: 1
• autoland: 1

Platform breakdown:

• linux1804-64-devedition: 2
• linux1804-64-shippable: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1644789&startday=2020-06-08&endday=2020-06-14&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 4035 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1644789&startday=2020-06-15&endday=2020-06-21&tree=all

Comment 6

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1644789 - Wait for Rule view to update before interacting with Flexbox toggle

Comment 7

[Razvan Caliman [:rcaliman]]

Looks like a race condition. Couldn't reproduce locally, but I think I fixed it.

The try run with latest mozilla central and this patch looks green. The early beta and late beta simulations I tried failed across the board with shutdown leaks. I followed the instructions for beta simulations, but perhaps I missed something.

Central try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=741491151655e5358f2e163096d5d39b8a577b8c

Early Beta simulation try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e57744512f3da5e4fd6fc8622a2c867b9a783a0

Late Beta simulation try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1092f36e7adb126e2b7093e681901fe7da437982

Ryan, are you able to cherry-pick this patch with the next simulation runs?
Or shall I land it and sheriffs can reopen it if it does not fix the failure?

Comment 8

[Razvan Caliman [:rcaliman]]

I did another Late Beta simulation on try where I let it run all tests instead of subsetting just to devtools tests.

Looking good this time. The browser_rules_flexbox-highlighter-on-mutation.js test does not show up as failed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37e411e3476a78d00eea816167615730464d60a1&test_paths=browser_rules_flexbox-highlighter-on-mutation.js

Got R+. Proceeding to land. Fingers crossed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5af40441df5a
Wait for Rule view to update before interacting with Flexbox toggle r=gl

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5af40441df5a

Comment 11

[Intermittent Failures Robot]

3 failures in 5252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• autoland: 2

Platform breakdown:

• macosx1014-64-shippable: 2
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1644789&startday=2020-06-22&endday=2020-06-28&tree=all