Keyboard interrupt on ./mach puppeteer-test doesn't kill all child processes
Categories
(Remote Protocol :: Agent, defect, P2)
Tracking
(Not tracked)
People
(Reporter: impossibus, Unassigned)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [puppeteer-beta2-mvp])
STR: run ./mach puppeteer-test then hit ^C (twice)
Result: the npm process is killed but not the child node process (mocha) nor the child Firefox process(es)
|
||
Comment 1•4 years ago
|
||
Is that a new regression from that sync and it didn't happen before? I always faced problems with using Ctrl+C for interrupting the Puppeteer unit tests.
|
Reporter | |
Comment 2•4 years ago
|
||
I think it's a regression due to how mocha is called. Ctrl+C worked better for me before the sync.
|
|
||
Comment 3•4 years ago
|
||
Puppeteer 4.0.0 fixed it. So we may want to just downstream sync again?
|
|
Reporter | |
Comment 6•4 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)
Puppeteer 4.0.0 fixed it. So we may want to just downstream sync again?
The problem is the same with 4.1, both with Firefox and Chrome, so I still think it's due to how mach launches mocha.
|
|
Reporter | |
Updated•4 years ago
|
|
|
||
Comment 7•4 years ago
|
||
As noticed today this behavior results in a terrible user experience. Whenever I hit Ctrl+C to abort a puppeteer unit test job via mach the mocha node.js job spawns itself over and over again. I was not able to find a way to actually kill the process, and was forced to close x-amount of firefox processes until all the tests have been processed.
We should get this fixed as part of beta2 to allow us to run local puppeteer tests without issues.
|
|
Reporter | |
Comment 8•4 years ago
|
||
It might help to call mocha directly from mach instead of npm test. See https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/remote/test/puppeteer/package.json#11
|
||
Updated•3 years ago
|
|
|
||
Comment 9•1 year ago
|
||
This is no longer a problem.
Description
•