1644829 - Make all APZ subtests use the is/ok/etc functions that emit the subtest name

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

If there's a subtest running via runSubtestsSeriallyInFreshWindows, it can use the is, ok, etc. functions installed by runSubtestsSeriallyInFreshWindows which emit the subtest filename as well. Some subtests don't do this and so looking at the output from the full test run it's less obvious which subtest is running.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1644829 - For consistency ensure all tests that use runSubtestsSeriallyInFreshWindows have a _group in the name. r?botond

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1644829 - Add an `isnot` reflection to the subtest window as well. r?botond

Depends on D79170

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1644829 - Avoid using SimpleTest.is etc. in helper subtests run by runSubtestsSeriallyInFreshWindows. r?botond

Using SimpleTest.is directly instead of the "global" is installed by
runSubtestsSeriallyInFreshWindows means that the helper test filename doesn't
get emitted in the assertions, which is a nice thing to have. (Ditto for ok
and friends).

Problematic tests identified using:

for helper in helper_*.html; do
    if [[ $(grep "$helper" test_group*) ]]; then
        echo $helper;
        grep -e 'SimpleTest.\(is\|ok\)' "$helper";
    fi;
done

While it would be nice to catch this sort of thing directly in the code, it's
a bit tricky to do because SimpleTest.(ok|is) do get used legitimately by helper
methods that are used by group subtests and top-level tests.

Depends on D79171

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7adac05ff314
For consistency ensure all tests that use runSubtestsSeriallyInFreshWindows have a _group in the name. r=botond
https://hg.mozilla.org/integration/autoland/rev/affabc9da77a
Add an `isnot` reflection to the subtest window as well. r=botond
https://hg.mozilla.org/integration/autoland/rev/5fc6a75cec34
Avoid using SimpleTest.is etc. in helper subtests run by runSubtestsSeriallyInFreshWindows. r=botond

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7adac05ff314
https://hg.mozilla.org/mozilla-central/rev/affabc9da77a
https://hg.mozilla.org/mozilla-central/rev/5fc6a75cec34