1644848 - avoid Promise contructor anti-pattern in wpt event RTCPeerConnection-helper.js to surface errors.

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We're seeing some TIMEOUTs in RTCRtpReceiver-getSynchronizationSources.https.html in windows 7 debug builds.

It looks something may be failing in our implementation, but the failure may be covered up as a timeout in the listenForSSRCs helper:

function listenForSSRCs(t, receiver) {
  return new Promise((resolve) => {
    function listen() {
=>    const ssrcs = receiver.getSynchronizationSources(); // throws?
=>    assert_true(ssrcs != undefined); // throws?
      if (ssrcs.length > 0) {
        resolve(ssrcs);
        return;
      }
      t.step_timeout(listen, 0);
    };
    listen();
  });
}

setTimeout has terrible error-handling characteristics, so these should be rewritten to avoid the Promise constructor anti-pattern to better surface errors in the test harness.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1644848 - avoid Promise contructor anti-pattern in event RTCPeerConnection-helper.js to surface errors to harness.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #0)

We're seeing some TIMEOUTs in RTCRtpReceiver-getSynchronizationSources.https.html in windows 7 debug builds.

Or rather we were seeing timeouts before the main thread rescheduling, which is what the above link is, i.e. unexpected PASS:

The [task 2020-06-10T11:31:54.373Z] 11:31:54 INFO - TEST-UNEXPECTED-PASS | /webrtc/RTCRtpReceiver-getSynchronizationSources.https.html | [audio] getSynchronizationSources() eventually returns a non-empty list - expected TIMEOUT

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a45dbff163be61d5d1b562b7d1d8fe823e519df8

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae204fc7db060ade07ec10871105ff994b10df38

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab4006856bdc
avoid Promise contructor anti-pattern in event RTCPeerConnection-helper.js to surface errors to harness. r=ng,bwc

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24138 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/24138
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/YY42N_lpTnmwsdkQmsT3yA)

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ab4006856bdc

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/53b0e2749170