1644883 - Compositor thread isn't shut down properly

Status: NEW

(Core :: Graphics, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The Compositor thread isn't shut down when we drop the CompositorThreadHolder, which means nsThreadManager has to clean it up later.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1644883: Shut down Compositor thread on Shutdown r=mattwoodrow

Comment 2

[Jean-Yves Avenard [:jya]]

See Bug 1644254 which is relevant to this.

The issue is that the APZ and Canvas (and I think the VR manager) are dispatches task on the compositor thread after CompositorThreadHolder::Shutdown() has been called.

It didn't cause problem earlier because the compositor thread was a google's MessageLoop.

So if we do shutdown the thread in here, or in the CompositorThreadHolder singleton destructor ; those tasks dispatched would never run.
I don't know if that is a problem or not; but my guess leaking that thread isn't something to be worried about

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.