1644945 - Add an nsIParentChannel wrapper class for ParentProcessDocumentChannel so that we can share code

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Matt Woodrow (:mattwoodrow)]

DocumentLoadListener currently has fairly different code during redirect to real channel to handle the in-process (ParentProcessDocumentChannel) vs OOP cases (DocumentChannelParent).

We can implement nsIParentChannel for PPDC to make them more similar.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1644945 - Implement a wrapper nsIParentChannel for ParentProcessDocumentChannel so that we can use the same code in DocumentLoadListener. r?jya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05e436fbc095
Implement a wrapper nsIParentChannel for ParentProcessDocumentChannel so that we can use the same code in DocumentLoadListener. r=jya

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for Linux bustage on DocumentLoadListener.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/776d8aae92dd7755621e5958d8eff68a83a05843

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2C%28bb%29&revision=05e436fbc095956356421978a548db389d000ed8&selectedTaskRun=Ck_eI68dRmOb7DU5cmnwKA.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306092010&repo=autoland&lineNumber=21663

[task 2020-06-12T11:36:01.859Z] 11:36:01 INFO - In file included from Unified_cpp_netwerk_ipc0.cpp:38:0:
[task 2020-06-12T11:36:01.860Z] 11:36:01 INFO - /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp: In member function 'void mozilla::net::DocumentLoadListener::FinishReplacementChannelSetup(nsresult)':
[task 2020-06-12T11:36:01.860Z] 11:36:01 ERROR - /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:778:8: error: variable 'disconnected' set but not used [-Werror=unused-but-set-variable]
[task 2020-06-12T11:36:01.861Z] 11:36:01 INFO - bool disconnected = false;
[task 2020-06-12T11:36:01.861Z] 11:36:01 INFO - ^~~~~~~~~~~~
[task 2020-06-12T11:36:01.861Z] 11:36:01 INFO - cc1plus: all warnings being treated as errors
[task 2020-06-12T11:36:01.861Z] 11:36:01 INFO - /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Unified_cpp_netwerk_ipc0.o' failed
[task 2020-06-12T11:36:01.861Z] 11:36:01 ERROR - make[4]: *** [Unified_cpp_netwerk_ipc0.o] Error 1
[task 2020-06-12T11:36:01.861Z] 11:36:01 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/ipc'
[task 2020-06-12T11:36:01.862Z] 11:36:01 INFO - /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'netwerk/ipc/target-objects' failed
[task 2020-06-12T11:36:01.862Z] 11:36:01 ERROR - make[3]: *** [netwerk/ipc/target-objects] Error 2
[task 2020-06-12T11:36:01.862Z] 11:36:01 INFO - make[3]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/308399471b6e
Implement a wrapper nsIParentChannel for ParentProcessDocumentChannel so that we can use the same code in DocumentLoadListener. r=jya

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/308399471b6e