1644966 - Make ConsoleApiListener and ConsoleServiceListener take a function instead of an object

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, those listener take an object as their second argument, which must contain one specific property (resp onConsoleAPICall and onConsoleServiceMessage).
The object isn't used for anything else.

The whole workflow would be easier to follow if we were directly passing the function.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1644966 - Change second parameter of ConsoleServiceListener to a function. r=jdescottes.

It used to take an object with only 1 property, a function. The way it was
called in the webconsole actor made it harder to follow than it actually need.
We take that as an opportunity to convert the function to a class.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1644966 - Change second parameter of ConsoleAPIListener to a function. r=jdescottes.

It used to take an object with only 1 property, a function. The way it was
called in the webconsole actor made it harder to follow than it actually need.
We take that as an opportunity to convert the function to a class.

Depends on D79249

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1644966 - Change parameter of ContentProcessListener to a function. r=jdescottes.

It used to take an object with only 1 property, a function. The way it was
called in the webconsole actor made it harder to follow than it actually need.
We take that as an opportunity to convert the function to a class.

Depends on D79252

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f48c3a894b8a
Change second parameter of ConsoleServiceListener to a function. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/6b38bfc53cf3
Change second parameter of ConsoleAPIListener to a function. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/0da6f494ad2c
Change parameter of ContentProcessListener to a function. r=jdescottes.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f48c3a894b8a
https://hg.mozilla.org/mozilla-central/rev/6b38bfc53cf3
https://hg.mozilla.org/mozilla-central/rev/0da6f494ad2c