1644992 - JSWindowActorProtocol::Observe should report a browser console error / warning if the subject isn't an inner/outer window

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[:Gijs (he/him)]

Current code is:

  nsCOMPtr<nsPIDOMWindowInner> inner = do_QueryInterface(aSubject);
  RefPtr<WindowGlobalChild> wgc;

  if (!inner) {
    nsCOMPtr<nsPIDOMWindowOuter> outer = do_QueryInterface(aSubject);
    if (NS_WARN_IF(!outer) || NS_WARN_IF(!outer->GetCurrentInnerWindow())) {
      return NS_ERROR_FAILURE;
    }
    wgc = outer->GetCurrentInnerWindow()->GetWindowGlobalChild();
  } else {
    wgc = inner->GetWindowGlobalChild();
  }

  if (NS_WARN_IF(!wgc)) {
    return NS_ERROR_FAILURE;
  }

The observer service will swallow the NS_ERROR_FAILURE, so failure is mostly silent except on debug builds, where I think warnings are likely to get lost in the rest of the stdout/stderr maelstrom.

I think we should report an error in the console service with the actor name and observer topic, so we're more likely to notice / understand why the observer interaction with the child actor "doesn't work".

Comment 1

[Chris Peterson [:cpeterson]]

This is a feature request from Frontend team.

Tracking for Fission Nightly M6b

Comment 2

[u608768]

Attachment: Bug 1644992

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1644992 - Report an error for non-window topic observed by JSWindowActorProtocol,

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/886855bf6308
Report an error for non-window topic observed by JSWindowActorProtocol, r=kmag

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/886855bf6308