1645054 - When dom.serviceWorkers.enabled is false, interception should be disabled and existing registrations should be purged on startup

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Andrew Sutherland [:asuth] (he/him)]

As pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=1641012#c12 the dom.serviceWorkers.enabled preference doesn't actually prevent interception by already-installed ServiceWorkers.

I think it's likely appropriate to take the 2 following actions in general when the preference is disabled:

1. Disable interception when the pref is disabled.
2. Purge existing registrations on startup if the preference is disabled.

This would allow use of the preference at runtime to do quick A/B testing with/without ServiceWorkers, and then help ensure cleanup of existing ServiceWorkers if someone restarts Firefox.

Purging the registrations is also consistent with what we're doing as we introduce WebExtension manifest v3 ServiceWorker support, and in fact we can build on the logic and tests added by those cases:

• https://phabricator.services.mozilla.com/D60244 adds a if (!StaticPrefs::extensions_backgroundServiceWorker_enabled_AtStartup()) { check in ServiceWorkerManager::LoadRegistration
• https://phabricator.services.mozilla.com/D73326 adds a marionette test that verifies that the preference actually works.

Comment 1

[Joshua Marshall]

Attachment: WIP: Bug 1645054 - Disable/purge service workers when dom.serviceWorkers.enabled is false r=dom-worker-reviewers!

Comment 2

[Joshua Marshall]

Attachment: Bug 1645054 - Disable/purge service workers when dom.serviceWorkers.enabled is false r=#dom-worker-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c46706c118
Disable/purge service workers when dom.serviceWorkers.enabled is false r=dom-worker-reviewers,necko-reviewers,asuth,webdriver-reviewers,whimboo

Comment 4

[Marian-Vasile Laza]

Backed out changeset 06c46706c118 (Bug 1645054) for marionette failures.
Backout link
Push with failures <--> Mn
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95bc0e834075
Disable/purge service workers when dom.serviceWorkers.enabled is false r=dom-worker-reviewers,necko-reviewers,asuth,webdriver-reviewers,whimboo

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/95bc0e834075