1645071 - WebRequest.jsm should not await onSendHeaders event dispatch

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P5)

Description

[Rob Wu [:robwu]]

https://searchfox.org/mozilla-central/rev/4bb2401ecbfce89af06fb2b4d0ea3557682bd8ff/toolkit/components/extensions/webrequest/WebRequest.jsm#1038

      if (kind === "onBeforeSendHeaders" && this.listeners.onSendHeaders.size) {
        await this.runChannelListener(channel, "onSendHeaders");

This await should be removed because webRequest.onSendHeaders is not a blocking listener. This event is informational only..

Comment 1

[Rob Wu [:robwu]]

This is really easy to fix. Literally removing just one word.

This is a good first bug for those who want to get familiar with setting up a development environment and submitting a patch.
To get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Comment 2

[Brenda M Lima]

Hi :robwu, I'm Brenda and I'm trying to enroll on outreachy, can I start my contribution with this one? Thanks in advance!

Comment 3

[Rajreet]

Hi :robwu , I am new to opensource and would like to contribute. But where do I do so? Do I do so from github?

Comment 4

[Rob Wu [:robwu]]

(In reply to Brenda M Lima from comment #2)

Hi :robwu, I'm Brenda and I'm trying to enroll on outreachy, can I start my contribution with this one? Thanks in advance!

Yes you can.

(In reply to Rajreet from comment #3)

Hi :robwu , I am new to opensource and would like to contribute. But where do I do so? Do I do so from github?

Brenda, has expressed interest in this bug before, so I suggest that you try out a different good-first-bug bug (we have plenty).
To get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Comment 5

[Brenda M Lima]

(In reply to Rob Wu [:robwu] from comment #4)

(In reply to Brenda M Lima from comment #2)

Hi :robwu, I'm Brenda and I'm trying to enroll on outreachy, can I start my contribution with this one? Thanks in advance!

Yes you can.

(In reply to Rajreet from comment #3)

Hi :robwu , I am new to opensource and would like to contribute. But where do I do so? Do I do so from github?

Brenda, has expressed interest in this bug before, so I suggest that you try out a different good-first-bug bug (we have plenty).
To get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Thanks, I'm on it

Comment 6

[Brenda M Lima]

Attachment: Bug 1645071 - remove await from non-blocking listener. r?robwu

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:brendanatalia94, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Tomislav Jovanovic :zombie]

Hey Rob, can you please check if this is still good to land, and land it?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71cfdbebac8e
remove await from non-blocking listener. r=robwu

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/71cfdbebac8e

Comment 11

[Caitlin Neiman [:caitmuenster]]

Thank you so much for the patch, Brenda! 🎉 Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Hope to see you around the project in the future!