[wpt-sync] Sync PR 24113 - Reland "webauthn: implement getPublicKey() and friends."
Categories
(Core :: DOM: Web Authentication, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24113 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24113
Details from upstream follow.
Adam Langley <agl@chromium.org> wrote:
Reland "webauthn: implement getPublicKey() and friends."
This reverts commit e2c1b358db1755a91f62f4c27a1d220bd326c742.
https://chromium-review.googlesource.com/c/chromium/src/+/2238777 updates some Java tests with non-dummy data that should avoid causing problems.
Original change's description:
Revert "webauthn: implement getPublicKey() and friends."
This reverts commit c5d236776cd30849a65ca626e51cd19e651da7c6.
Reason for revert: I suspect that this CL causes Fido2CredentialRequestTest failures on android-pie-x86-rel:
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-relHere is a snippet of callstack:
java.lang.AssertionError: expected:\<11> but was:\<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.chromium.chrome.browser.webauth.Fido2CredentialRequestTest.testMakeCredential_attestationIndirect(Fido2CredentialRequestTest.java:921)Original change's description:
webauthn: implement getPublicKey() and friends.
This change implements the getPublicKey(), getPublicKeyAlgorithm(), and
getAuthenticatorData() functions described in the editor's draft of
WebAuthn level two[1].[1] https://w3c.github.io/webauthn/#sctn-public-key-easy
BUG=1083301
Change-Id: I3a03279d5239a9f8df50a78f2166f30d01d38d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204087
Reviewed-by: Andrew Grieve \<agrieve@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Reviewed-by: Alex Russell \<slightlyoff@chromium.org>
Reviewed-by: Jared Saul \<jsaul@google.com>
Reviewed-by: Adam Langley \<agl@chromium.org>
Reviewed-by: Nina Satragno \<nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer \<martinkr@google.com>
Commit-Queue: Adam Langley \<agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776517}TBR=kenrb@chromium.org,agl@chromium.org,slightlyoff@chromium.org,nsatragno@chromium.org,agrieve@chromium.org,jsaul@google.com,martinkr@google.com
Change-Id: I7429b5b7ecd7fa38c4e1ec2905b80a15e7c64216
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1083301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238749
Reviewed-by: Pavel Yatsuk \<pavely@chromium.org>
Commit-Queue: Pavel Yatsuk \<pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776637}TBR=kenrb@chromium.org,agl@chromium.org,slightlyoff@chromium.org,pavely@chromium.org,nsatragno@chromium.org,agrieve@chromium.org,jsaul@google.com,martinkr@google.com
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1083301
Change-Id: I9e3c8278dde4b61b7a45b6277f48fe018b3a8188Reviewed-on: https://chromium-review.googlesource.com/2241341
WPT-Export-Revision: 6920b97e4d53ca5ee025dd4b4eb478c02b43e487
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 4 subtests
Status Summary
Firefox
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Chrome
OK : 2
PASS : 5
FAIL : 1
Safari
FAIL : 1
TIMEOUT: 4
NOTRUN : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/webauthn/createcredential-getpublickey.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
], TIMEOUT [GitHub
] (Chrome: OK, Safari: TIMEOUT)
WebAuthn getPublicKey: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/webauthn/webauthn-testdriver-basic.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
], TIMEOUT [GitHub
] (Chrome: OK, Safari: TIMEOUT)
Get an assertion: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Create a credential: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Clean up the test environment: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Set up the test environment: FAIL (Chrome: PASS, Safari: FAIL)
Tests Disabled in Gecko Infrastructure
/webauthn/createcredential-getpublickey.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
], TIMEOUT [GitHub
] (Chrome: OK, Safari: TIMEOUT)
/webauthn/webauthn-testdriver-basic.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
], TIMEOUT [GitHub
] (Chrome: OK, Safari: TIMEOUT)
Comment 4•4 years ago
|
||
bugherder |
Description
•