1645132 - Text layout of very big text nodes can end up causing negative isize assertions to fire.

Status: RESOLVED DUPLICATE of bug 1751828

(Core :: Layout: Text and Fonts, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This was hit by Andreas while trying to write a DOM test.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1645132 - Use NSToCoordCeilClamped to prevent overflow when laying out very big text nodes. r=jfkthame

The test in D79145 hits a negative isize assertion because of this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe18d84dddfc
Use NSToCoordCeilClamped to prevent overflow when laying out very big text nodes. r=jfkthame

Comment 3

[Razvan Maries]

Backed out for perma failures on 478185-1.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Cdebug%2Creftests%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-crashtest-e10s%2Cr%28c%29&revision=fe18d84dddfc4b7ee7158115778caae23e4b0fdf&selectedTaskRun=dHLMtbO6QzmCjkj_PRnp6Q.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306003044&repo=autoland&lineNumber=11364

Backout: https://hg.mozilla.org/integration/autoland/rev/28083ec205b07a4ffd3eac5f4a7476dbcee11986

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Probably the assertion count should be adjusted, will look into it later.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emilio, could you have a look please?
For more information, please visit auto_nag documentation.