Closed Bug 1645165 Opened 4 years ago Closed 4 years ago

Migration Wizard shows the default ("Introduction") title on the source selection page

Categories

(Firefox :: Migration, defect)

Desktop
Unspecified
defect

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 --- verified

People

(Reporter: MattN, Assigned: Gijs)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(1 file)

"Import Settings and Data" is the string that's supposed to show but the default string "Introduction" is showing instead (in many but not all cases?). Perhaps this is because there is a race between the Fluent code for migration and the .properties code for the default value? It seems to happen mostly upon first run with --migration but the first time I saw the problem was near startup.

STR 1:

  1. Run Firefox with --migration
  • macOS example: /Applications/FirefoxNightly.app/Contents/MacOS/firefox --no-remote --profile /tmp/import`date +%s` --migration

https://searchfox.org/mozilla-central/search?q=%5Cbimport-%3Fsource%5Cb&path=migration&case=false&regexp=true

Gijs, is there a bug to convert https://searchfox.org/mozilla-central/search?q=default-first-title-mac&path=&case=false&regexp=false to Fluent? Is that bug 1627051?

Flags: qe-verify+
Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Matthew N. [:MattN] from comment #0)

Gijs, is there a bug to convert https://searchfox.org/mozilla-central/search?q=default-first-title-mac&path=&case=false&regexp=false to Fluent? Is that bug 1627051?

Yes, but we have 2 wizard consumers, and TB has like 10, and I feel bad about just breaking stuff from under them (which I've been doing a lot lately).

Anyway, the wizard code is supposed to work if the dialog sets a string, not overwrite things, so it would seem we could/should "just" fix the race condition instead.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Depends on: 1645246
No longer depends on: 1645246
See Also: → 1645246
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/43dd99f85176
fix header labels in migration dialog, r=MattN,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Successfully reproduced the issue on Firefox 79.0a1 (2020-06-11) under macOS 10.15.5 following the STR from Comment 0.

This issue is fixed on Firefox 79.0a1 (2020-06-17). Tests were performed on macOS 10.15.5, Ubuntu 20.04 (x64) and Windows 10 (x64).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.