1645179 - Squash remaining dead code after removal of IMPACTED_TESTS

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Ricky Stewart]

After bug 1644228 we'll be left with a bunch of code, originating from bug 1184405, that is either dead or bitrotted to the point of being broken or useless. All that should be deleted, or else we should come to a robust understanding of why it's useful and should be kept around/fixed.

Comment 1

[Ricky Stewart]

Attachment: Bug 1645179 - Squash remaining dead code after removal of IMPACTED_TESTS

There is some remaining code in central originating from bug 1184405, which sought to associate source files with their "affected" test files. That ended up not panning out, and bug 1644228 removed a lot of that code, but left some remnants in the Files object which are still referenced in a couple different places. I'm deleting all of that code in context.py plus everything that references it for the following reasons:

1. Right now, Files.{test_files,test_tags,test_flavors} do get populated, but only ever with "default" values -- namely moz.build files that are above the files in question in the directory hierarchy. This is a heuristic that doesn't actually have anything to do with mapping source files to their corresponding test files, which is misleading.

2. Those attributes are accessed in two places. The first is in the mach file-info dep-tests command. This command isn't referenced anywhere else in tree and I don't have any evidence anyone ever uses it. Even if they do, I would claim that doing so is a mistake (because the results of the command aren't meaningful and are just populated by the "defaults" described above), and that person's workflow should be migrated to something else that is meaningful.

3. The second place where this metadata is accessed is in testing/mozbase/moztest/moztest/resolve.py; that method is invoked in tools/tryselect/selectors/syntax.py, but only if you pass --detect-paths to mach try syntax. This is entirely broken, and even if we made an effort to fix it, it wouldn't do anything resembling what the documentation of --detect-paths suggests it would do (again, because the data isn't populated meaningfully). So I'm deleting the command line option entirely.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76f4abf199e2
Squash remaining dead code after removal of IMPACTED_TESTS r=ahal,froydnj

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/76f4abf199e2