1645180 - CSS use counters underreport after bug 1599160

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

When we hit the cache introduced in bug 1599160, we don't save our use counters, which means that we don't report the right CSS properties parsed.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This also means that the "zoom" warnings and such are not reported consistently.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1645180 - Allow to cache data: stylesheets across documents. r=#style

This is useful, simplifies testing this bug, and also matches the image
cache:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/image/imgLoader.cpp#1867-1870

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1645180 - Don't under-report use counters for documents that hit the shared sheet cache. r=#style

This makes us refactor a bit more our setup but I think the end it's
worth it.

Depends on D79376

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1645180 - Refactor test use counters to be less repetitive, and also test <link>. r=#style

Without the previous patch, the tests for the second iframe fail.

Depends on D79377

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80e9e9e78e5e
Allow to cache data: stylesheets across documents. r=firefox-style-system-reviewers,heycam
https://hg.mozilla.org/integration/autoland/rev/8dc9d9e4f96b
Don't under-report use counters for documents that hit the shared sheet cache. r=firefox-style-system-reviewers,heycam
https://hg.mozilla.org/integration/autoland/rev/eebb849d100e
Refactor test use counters to be less repetitive, and also test <link>. r=firefox-style-system-reviewers,heycam

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80e9e9e78e5e
https://hg.mozilla.org/mozilla-central/rev/8dc9d9e4f96b
https://hg.mozilla.org/mozilla-central/rev/eebb849d100e