Closed
Bug 1645189
Opened 6 years ago
Closed 6 years ago
Browsertime perfherder data should use the `pageload` type not `browsertime-pageload`
Categories
(Testing :: Raptor, defect, P3)
Testing
Raptor
Tracking
(firefox79 fixed)
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: sparky, Assigned: rogheliavandan, Mentored)
References
Details
(Keywords: good-first-bug)
User Story
Attachments
(1 file)
Currently our browsertime perfherder data has the browsertime-pageload type, but it should have the pageload type.
| Reporter | ||
Updated•6 years ago
|
Keywords: good-first-bug
| Reporter | ||
Comment 3•6 years ago
|
||
Hi :vandan, if you look in the new contributors guide, you'll find how you can run a browsertime test. At the end of the test you will see a PERFHERDER_DATA log containing data and you will have to make sure that the type field uses pageload instead of browsertime-pageload.
Good news! PERFHERDER_DATA log was containing "type": "pageload". Patch has been tested locally successfully and it works.
| Reporter | ||
Comment 5•6 years ago
|
||
That's awesome! So now to submit your first patch through phabricator :)
Updated•6 years ago
|
Assignee: nobody → rogheliavandan
Status: NEW → ASSIGNED
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/281dea8a4d10
Changed `browsertime-pageload` to `pageload` type. r=sparky,perftest-reviewers,Bebe
Comment 8•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•