1645197 - Browsertime visualmetrics data is missing a `type` entry in the perfherder data

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P3)

Description

[Greg Mierzwinski [:sparky]]

The browsertime visual-metrics data is missing the type entry in the perfherder data. It should be set to pageload.

Comment 1

[Vandan]

Hi! I would like to submit a patch for this bug.

Comment 2

[Greg Mierzwinski [:sparky]]

Hi :vandan! That's great, you'll have to modify this file to add the missing type entry to the perfherder data: https://searchfox.org/mozilla-central/source/taskcluster/docker/visual-metrics/run-visual-metrics.py

It's currently not possible to test this locally, but I'll be able to tell if it's correct when you submit a patch.

Comment 3

[Vandan]

While looking into the file mentioned in comment2 I was able to find 'type' under 'perf_data', https://searchfox.org/mozilla-central/source/taskcluster/docker/visual-metrics/run-visual-metrics.py#284.

Should I edit the type to 'pageload' or add a different key with that type?

Comment 4

[Greg Mierzwinski [:sparky]]

That's right there is no existing type field being defined there. If you can add a type field (set to pageload) to the perf data that would solve this issue.

Comment 5

[Vandan]

Attachment: Bug 1645197 - Type pageload added to browsertime visualmetrics data. r=sparky

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5615d4126f9e
Type pageload added to browsertime visualmetrics data. r=sparky

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5615d4126f9e