Closed Bug 1645197 Opened 2 months ago Closed 2 months ago

Browsertime visualmetrics data is missing a `type` entry in the perfherder data

Categories

(Testing :: Raptor, defect, P3)

defect

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: sparky, Assigned: rogheliavandan, Mentored)

Details

(Keywords: good-first-bug)

User Story

https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

Attachments

(1 file)

The browsertime visual-metrics data is missing the type entry in the perfherder data. It should be set to pageload.

Keywords: good-first-bug

Hi! I would like to submit a patch for this bug.

Hi :vandan! That's great, you'll have to modify this file to add the missing type entry to the perfherder data: https://searchfox.org/mozilla-central/source/taskcluster/docker/visual-metrics/run-visual-metrics.py

It's currently not possible to test this locally, but I'll be able to tell if it's correct when you submit a patch.

While looking into the file mentioned in comment2 I was able to find 'type' under 'perf_data', https://searchfox.org/mozilla-central/source/taskcluster/docker/visual-metrics/run-visual-metrics.py#284.

Should I edit the type to 'pageload' or add a different key with that type?

That's right there is no existing type field being defined there. If you can add a type field (set to pageload) to the perf data that would solve this issue.

Assignee: nobody → rogheliavandan
Status: NEW → ASSIGNED
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/5615d4126f9e
Type pageload added to browsertime visualmetrics data. r=sparky
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.