1645231 - Back button menu doesn't show current entry without user interaction when navigated to from the page

Status: NEW

(Core :: DOM: Navigation, defect, P3)

Description

[Johann Hofmann [:johannh]]

STR:

1. On https://johann-hofmann.com/back-button, hover one of the lower buttons for 3s to initiate a navigation without user gesture.
2. Repeat step 1.
3. Hover the button for history.back() for 3s
4. Open the back button menu

You'll notice that the current entry is not shown as expected. It's hidden because technically it didn't have user interaction. We should probably still show it.

Comment 1

[Daniel Holbert [:dholbert]]

URL in comment 1 is 404; looks like we need a new testcase.

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: New testcase

I've provided what is hopefully an equivalent test case.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Adam Vandolder [:avandolder] from comment #2)

I've provided what is hopefully an equivalent test case.

Thanks! Could you write down some updated STR & expected/actual results for your testcase, too?

(Perhaps similar to comment 0, though comment 0 starts out talking about "one of the lower buttons" and in your testcase there are only 3 buttons all on the same line, so I'm not sure how different the STR are meant to be.)

Comment 4

[Adam Vandolder [:avandolder]]

Attachment: Fixed test case

(I noticed I had made a typo in the previous attachment, here's a fixed version)

New test case steps:

1. Enable browser.navigation.requireUserInteraction pref.
2. Hover over either of the "Next" buttons for at least 3 seconds, in any order, to generate a series of navigations.
3. Hover over the "Go Back" button for 3 seconds.
4. Check the back button menu; the current history entry will not appear in the list.

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug when hovering "next 1" / "next 2" just once

thanks. Just for completeness, here's a screencast of what I see with that testcase/STR -- it's subtle but I think I'm seeing the bug.

It looks like really browser.navigation.requireUserInteraction just makes us de-duplicate the entries in the back menu, I think?

That means repeated visits to a given URL (from hovering back and forth between the buttons in the testcase) only show up once in the back menu, and when you hover "go back" to navigate back to one of them, then it ~reasonably doesn't show up in the back menu since the visits to that site were de-duplicated into a single menu entry which you've just navigated back to.

[EDIT: er, my next comment here -- comment 6 -- has a screencast that more-clearly shows the de-duplication, particularly as compared to the reference behavior (with the pref set to false) in comment 7.]

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug when hovering "next 1" / "next 2" many times

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: screencast of reference behavior when browser.navigation.requireUserInteraction is false (default) and hovering "next 1" / "next 2" many times

Here's how this looks when browser.navigation.requireUserInteraction is false (the default). The history menu shows many entries, once for every time that I hovered "next 1" / "next 2" -- it's not de-duplicated as it was in the previous screencast.

Comment 8

[Daniel Holbert [:dholbert]]

Aha -- comparing the screencasts, I see that normally the back menu would show a bolded entry for the URL that you're currently viewing (that's present when the menu opens at the end of comment 7), and that bolded entry is completely absent in the buggy scenario (comment 5 / 6). That's presumably the main bug here.

Comment 9

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing the bolded/radio-button-selected current history entry (present at the bottom with default pref, missing at the top with toggled pref)