1645235 - Origin-counting telemetry for cookie purging is probably overcounting

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Johann Hofmann [:johannh]]

It doesn't take into account that we could count the same origin during multiple batches.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1645235 - Fix cookie purging telemetry. r=ewright

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c884124df9ac
Fix cookie purging telemetry. r=ewright

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_purge_trackers_telemetry.js

backout: https://hg.mozilla.org/integration/autoland/rev/fe8c1fceb1cfddf2592397f560f970022638ba0a

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c884124df9acf85ef1722f4df7c51f3ff289fd42&group_state=expanded&selectedTaskRun=Z0FqMZp3Q1S42-FoQW5_ZQ.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308325264&repo=autoland&lineNumber=7010

[task 2020-07-02T14:13:58.866Z] 14:13:58 INFO - TEST-START | toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js
[task 2020-07-02T14:13:59.701Z] 14:13:59 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js | xpcshell return code: 0
[task 2020-07-02T14:13:59.701Z] 14:13:59 INFO - TEST-INFO took 834ms
[task 2020-07-02T14:13:59.701Z] 14:13:59 INFO - >>>>>>>

[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - TEST-PASS | toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js | - Should have found an entry for COOKIE_PURGING_ORIGINS_PURGED at index 0 - true == true
[task 2020-07-02T14:13:59.704Z] 14:13:59 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js | - Should have found an entry for COOKIE_PURGING_TRACKERS_WITH_USER_INTERACTION at index 1 - false == true
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - resource://testing-common/TelemetryTestUtils.jsm:assertHistogram:304
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - Z:/task_1593697062/build/tests/xpcshell/tests/toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js:null:98
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - Z:\task_1593697062\build\tests\xpcshell\head.js:_do_main:248
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - Z:\task_1593697062\build\tests\xpcshell\head.js:_execute_test:577
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - -e:null:1
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - exiting test
[task 2020-07-02T14:13:59.704Z] 14:13:59 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - _abort_failed_test@Z:\task_1593697062\build\tests\xpcshell\head.js:833:20
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - do_report_result@Z:\task_1593697062\build\tests\xpcshell\head.js:934:5
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - Assert<@Z:\task_1593697062\build\tests\xpcshell\head.js:73:21
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - proto.report@resource://testing-common/Assert.jsm:233:10
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - proto.ok@resource://testing-common/Assert.jsm:259:10
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - assertHistogram@resource://testing-common/TelemetryTestUtils.jsm:304:12
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - @Z:/task_1593697062/build/tests/xpcshell/tests/toolkit/components/antitracking/test/xpcshell/test_purge_trackers_telemetry.js:98:22
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - _do_main@Z:\task_1593697062\build\tests\xpcshell\head.js:248:6
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - _execute_test@Z:\task_1593697062\build\tests\xpcshell\head.js:577:5
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - @-e:1:1
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - exiting test
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "NetworkError when attempting to fetch resource." {file: "resource://services-settings/Utils.jsm" line: 164}]
[task 2020-07-02T14:13:59.705Z] 14:13:59 INFO - fetchLatestChanges@resource://services-settings/Utils.jsm:164:28
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:426:37
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - get/this._importingPromise<@resource://services-settings/RemoteSettingsClient.jsm:362:24
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - observe@resource://gre/modules/AsyncShutdown.jsm:554:16
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - _execute_test@Z:\task_1593697062\build\tests\xpcshell\head.js:673:19
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - @-e:1:1
[task 2020-07-02T14:13:59.706Z] 14:13:59 INFO - "

Comment 4

[Erica Wright [:ewright]]

Thanks, I'll look after this, Johann is away.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab838556ed18
Fix cookie purging telemetry. r=ewright

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ab838556ed18

Comment 7

[Erica Wright [:ewright]]

Comment on attachment 9159055 [details]
Bug 1645235 - Fix cookie purging telemetry. r=ewright

Beta/Release Uplift Approval Request

• User impact if declined: None, but we will be collecting flawed data. The old telemetry counts once per piece of data being removed, not once per domain.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): no user facing change, this patch ensures we only send telemetry one time per page entry.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159055 [details]
Bug 1645235 - Fix cookie purging telemetry. r=ewright

Approved for 79.0b5. If we can verify that the Telemetry data we're receiving is fixed, that would be a good thing.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/96fd9c973fcb