1645237 - Load JSONView converter-observer lazily via static component registration

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, task)

Description

[Kris Maglione [:kmag]]

JSON View's content sniffing and converter components are currently registered in every process dynamically by a process script. This isn't ideal since it adds startup overhead and consumes somewhere over 10KB of memory in every content process, even when JSON View won't ever be used.

The easiest way to deal with this is to register both components statically, so that they're lazily loaded only when needed. For the content sniffer, this will unfortunately wind up causing it to load in every content process anyway, since we currently run content sniffers for every request in both the parent and content process. In the near(ish) future, though, we'll only run them in the parent, which means they'll never need to be loaded in the child.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1645237: Lazily load JSONView components via static registration. r=Honza

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edd253d8858c
Lazily load JSONView components via static registration. r=Honza

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/edd253d8858c

Comment 4

[Florin Strugariu [:Bebe]]

== Change summary for alert #26253 (as of Wed, 17 Jun 2020 13:12:20 GMT) ==

Improvements:

1% Base Content JS windows10-64-shippable-qr opt 3,790,791.00 -> 3,771,757.33
0.49% Base Content JS macosx1014-64-shippable opt 3,734,215.50 -> 3,716,049.33
0.48% Base Content JS windows10-64-shippable opt 3,789,619.00 -> 3,771,424.67
0.31% Base Content JS linux1804-64-shippable-qr opt 3,713,216.00 -> 3,701,600.67
0.31% Base Content JS linux1804-64-shippable-qr opt 3,713,216.00 -> 3,701,753.67
0.29% Base Content JS linux1804-64-shippable opt 3,712,661.33 -> 3,701,724.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26253