1645286 - Click on add-on title text in the manager produces a "The address wasn´t understood" error

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Pablo]

Attachment: extension.png

Description
The address wasn´t understood error when opening DDG addon

Environments
Windows 10

Tested with
Firefox 78.0b5 , (reproducible)
Firefox nightly 79.0a1 (june11) , (reproducible)
Firefox 77.0.1 (not reproducible)

STEPS

• Download latest Beta firefox build, (in my case im using Romanian but happens on any)
• Launch firefox
• Install addon https://addons.mozilla.org/en-US/firefox/addon/duckduckgo-for-firefox
• go to about:addons
• Click extensions on the left hand side
• click inside the duckduckgo addon

Actual Results
Error page:

The address wasn´t understood

Firefox doesnt know how to open this address,because of the following
protocols (addons) isn´t associated to any program.

Expected Result
addon settings should open.

**Notes **
I am getting this randomly, sometimes i enter about:Addons and i click on the addon and it gives the error, sometimes it does not five any error and i see the addon settings.

Comment 1

[Mark Banner (:standard8)]

Moving across to Add-on manager since that's where this is. I took a brief look at the console, but nothing obvious was showing up.

Comment 2

[zesanup]

I'm pretty sure this is the bug I am also encountering. On Firefox 78 beta:

Clicking on the box of any add-on is fine and works normally. However, clicking on the title text of any add-on leads to this error. Hovering over the title text shows the URL "addons://detail/{extension-id}". This works on all add-ons.

Comment 3

[zesanup]

More observations:

• Clicking on Try Again somehow correctly opens the add-on details page. After that everything works fine.
• Clicking on the back button from the error page takes you back to the add-on manager, but every add-on is vanished and most of the buttons don't respond.

Comment 4

[Mark Banner (:standard8)]

@zesanup: Thanks for working that out, I see exactly the same - clicking on the title text is broken.

[Tracking Requested - why for this release]: Broken functionality that is easily reproducible and likely to be hit by users.

Comment 5

[Andrew Swan [:aswan]]

I quickly bisected this and it led to bug 1637869, though I haven't examined that bug any more closely.
I think it may be a red herring, I'm not sure why any addons:... ids are being put into href properties -- these are not valid urls but are identifiers used internally as "view ids". Navigation inside about:addons is handled by click handlers, maybe we're just missing a preventDefault() somewhere and the bug mentioned above changed timing which led to the observable change in behavior?
Mark, what do you think?

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

This sounds like a duplicate of bug 1642235?

Comment 7

[Mark Striemer [:mstriemer]]

Attachment: Bug 1645286 - Load detail page in about:addons when clicking add-on name r?rpl

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a0e060baa82
Load detail page in about:addons when clicking add-on name r=rpl

Comment 9

[Mark Striemer [:mstriemer]]

This looks like a dupe of bug 1642235 to me. Bug 1642235 comment 11 explains the change that caused the regression. I'll comment on that bug requesting it be duped if there's no work on the DOM end related to this regression.

Comment 10

[Mark Striemer [:mstriemer]]

Comment on attachment 9156987 [details]
Bug 1645286 - Load detail page in about:addons when clicking add-on name r?rpl

Beta/Release Uplift Approval Request

• User impact if declined: Clicking on the name of an add-on in the list view will give an error page. This is especially bad for keyboard users where the add-on name is the primary way of opening the detail page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the list view at about:addons

2. Click on an add-on's name (it should show a URL at the bottom of the screen, since it's an <a> tag)

3. Verify the detail page is shown

4. Open the list view at about:addons

5. Use Tab to focus the add-on name link

6. Press Enter

7. Verify the add-on detail page is shown

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This simply adds an event.preventDefault() to avoid the navigation that now occurs after the platform change in bug 1637869. There is a new test for this case.
• String changes made/needed: None

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9156987 [details]
Bug 1645286 - Load detail page in about:addons when clicking add-on name r?rpl

approved for 78.0b8

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3427c474a5b7

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9a0e060baa82

Comment 15

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 78 beta 8 and Nightly 79.0a1 2020-06-17 under Win 10 64-bit, Ubuntu 18.04 64-bit and Mac OS X 10.15.