1645334 - ProcessDescriptorActor isn't passing its browsingContext when creating its WatcherActor

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The WatcherActor does have specific code to handle watching resources in parent process (devtools/server/actors/descriptors/watcher/watcher.js#188-200), by retrieving the browsingContextID from the browser option passed when instantiating it (devtools/server/actors/descriptors/watcher/watcher.js#35,57-59).

Unfortunately, in devtools/server/actors/descriptors/process.js#145, we're creating the WatcherActor for the ProcessDescriptorActor without the browser option, which means the watcherActor won't be able to retrieve the targetActor.
As a result, we won't watch resources in parent processes (you can see that by flipping the [Resources.TYPES.CONSOLE_MESSAGE] trait, opening the browser toolbox and evaluating console.log("bloup"); the bloup message won't appear).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1645334 - Handle parentProcessTargetActor in WatcherActor. r=jdescottes,ochameau.

The WatcherActor already has code to handle ParentProcessTargetActor, but since
the browsing context wasn't passed to the watcher actor when we were creating
it in the ProcessDescriptorActor, nothing was done (and we weren't watching
for resources on that target).
This patch fixes that, and also changes what the WatcherActor expects. It used
to take a whole browser object, but was only using it to retrieve the
browsing context id, so directly passing the id seems more straightforward.

Depends on D79294

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c124c1c7b2a4
Handle parentProcessTargetActor in WatcherActor. r=jdescottes,ochameau.

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c124c1c7b2a4